[release-4.9] Bug 2096802: duplicated IPs can be assigned to multiple Pods #1136
Conversation
This commit is is not a clean cherry-pick of 12848e7. This patch ensures that retry logic for pods is after syncPods is executed. This is accomplished serially with the AddPodHandler func's parameter 'processExisting' which we pass the syncPods func. This ensures we exec 'syncPods' once before calling the retry funcs. However, we need to fix the case where 'syncPods' fails in future patches. Also, when addNode() failed in addNodeAnnotations(), the node's IPAM can be overwritten by subsequent addNode() retry attempts. As the result, the same IP can be allocated to multiple pods. All credit to Yun Zhou (yunz@nvidia.com). Signed-off-by: Martin Kennelly <mkennell@redhat.com>
|
@martinkennelly: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
There is a noticeable difference backporting this change - |
martinkennelly
changed the title
openshift-ci
bot
added
bugzilla/severity-high
|
@martinkennelly: This pull request references Bugzilla bug 2096802, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
The retry mechanism for |
|
/bugzilla refresh |
|
@martinkennelly: This pull request references Bugzilla bug 2096802, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
martinkennelly
changed the title
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/valid-bug
|
@martinkennelly: This pull request references Bugzilla bug 2096802, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
1 similar comment
|
/retest |
|
/label backport-risk-assessed |
openshift-ci
bot
added
the
backport-risk-assessed
|
/assign @anuragthehatter |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: martinkennelly, trozet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
@martinkennelly: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@martinkennelly: All pull requests linked via external trackers have merged: Bugzilla bug 2096802 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This commit is is not a clean cherry-pick of
12848e7.
This patch ensures that retry logic for pods is after syncPods
is executed. This is accomplished serially with the AddPodHandler
func's parameter 'processExisting' which we pass the syncPods func.
This ensures we exec 'syncPods' once before calling the retry funcs.
However, we need to fix the case where 'syncPods' fails in future
patches.
Also, when addNode() failed in addNodeAnnotations(), the node's IPAM can be
overwritten by subsequent addNode() retry attempts. As the result, the
same IP can be allocated to multiple pods.
All credit to Yun Zhou (yunz@nvidia.com).
Signed-off-by: Martin Kennelly mkennell@redhat.com
/cc @trozet