Commits on Jun 15, 2022

1. gatewayCleanup doesn't delete rtoj* ports …

   Currently gatewayCleanup doesn't delete rtoj-* ports
   which is fine since it deletes the router and probably
   on the OVN side the ports on the router are also removed
   as they are dependent on the router. However from a testing
   perspective its nice to have the gatewayCleanup remove these
   ports explictly just like multiJoinSwitchGatewayCleanup does.
   
   Corresponding gatewayCleanup unit tests are also updated.
   
   We also add a unit test to egressip testing where we test
   reassignment upon egress node deletion, specifically where
   the node has already gotten deleted by the node watcher. This
   test uncovers a bug we have in egressIP code where the
   reassignment will not be successful and will fail with the error
   
   E0608 09:42:53.781497  971577 obj_retry.go:1513] Failed to delete resource object node1 of type *factory.egressNode, error: Re-assignment for EgressIP: egressip failed, unable to update object, err: unable to retrieve gateway IP for node: node1, protocol is IPv6: false, err: attempt at finding node gateway router network information failed, err: unable to find router port rtoj-GR_node1: object not found
   
   Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
   (cherry picked from commit 9d0aebe)

   

   tssurya committed Jun 15, 2022
   Copy the full SHA

   2100d49 View commit details

   Browse the repository at this point in the history

2. Fix egressIP object deletion if the node is deleted first …

   There are a few instances in egressIP code where we shouldn't
   fail hard if objects are not found, example if a node gets
   deleted before egressIP watcher takes action. In this case,
   we can log a warning saying objects couldn't be deleted and
   move on since its technically not an error if the object was
   deleted by some other code path.
   
   In oder to ensure we don't leave behind stale reroute policy
   entries, we also add the logic of removing policies that have
   nexthop == joinIP of the node that's getting deleted into the
   gateway cleanup code.
   
   Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
   (cherry picked from commit 95ab759)

   

   tssurya committed Jun 15, 2022
   Copy the full SHA

   95486d9 View commit details

   Browse the repository at this point in the history

3. SkipTest:should not do anyting for user defined status updates …

   Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
   (cherry picked from commit 35b4793)

   

   tssurya committed Jun 15, 2022
   Copy the full SHA

   619748b View commit details

   Browse the repository at this point in the history