Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2099755: Add new EgressIP config option "egressip-reachability-total-timeout" #1156

Merged
merged 1 commit into from Jun 23, 2022

Conversation

msherif1234
Copy link
Contributor

Users can change node's reachability total timeout from 1sec "default"
to different values using this new option.

Also it can be used to disable reachability check if users specify a value
of 0.

Signed-off-by: Mohamed Mahmoud mmahmoud@redhat.com
(cherry picked from commit 9e4358d)

Users can change node's reachability total timeout from 1sec "default"
to different values using this new option.

Also it can be used to disable reachability check if users specify a value
of 0.

Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
(cherry picked from commit 9e4358d)
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 22, 2022

@msherif1234: An error was encountered querying GitHub for users with public email (anusaxen@redhat.com) for bug 2099755 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 2099755: Add new EgressIP config option "egressip-reachability-total-timeout"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@msherif1234
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 22, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 22, 2022

@msherif1234: This pull request references Bugzilla bug 2099755, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyrtapz
Copy link
Contributor

kyrtapz commented Jun 22, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2022
@trozet
Copy link
Contributor

trozet commented Jun 22, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyrtapz, msherif1234, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD b56a7ba and 8 for PR HEAD 9baffac in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD b56a7ba and 7 for PR HEAD 9baffac in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD b56a7ba and 6 for PR HEAD 9baffac in total

@msherif1234
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2022

@msherif1234: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-hypershift 9baffac link false /test e2e-hypershift
ci/prow/e2e-ovn-hybrid-step-registry 9baffac link false /test e2e-ovn-hybrid-step-registry
ci/prow/e2e-vsphere-ovn 9baffac link false /test e2e-vsphere-ovn
ci/prow/4.11-upgrade-from-stable-4.10-local-gateway-e2e-aws-ovn-upgrade 9baffac link false /test 4.11-upgrade-from-stable-4.10-local-gateway-e2e-aws-ovn-upgrade
ci/prow/e2e-openstack-ovn 9baffac link false /test e2e-openstack-ovn
ci/prow/e2e-azure-ovn 9baffac link false /test e2e-azure-ovn
ci/prow/e2e-aws-ovn-serial 9baffac link false /test e2e-aws-ovn-serial
ci/prow/e2e-aws-ovn-windows 9baffac link false /test e2e-aws-ovn-windows
ci/prow/e2e-vsphere-windows 9baffac link false /test e2e-vsphere-windows
ci/prow/okd-e2e-gcp-ovn 9baffac link false /test okd-e2e-gcp-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit aa43c16 into openshift:master Jun 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2022

@msherif1234: All pull requests linked via external trackers have merged:

Bugzilla bug 2099755 has been moved to the MODIFIED state.

In response to this:

Bug 2099755: Add new EgressIP config option "egressip-reachability-total-timeout"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants