Bug 2100220: Fix completed pods releasing IP address on update #1158
Conversation
Previous to generic watcher/retry library we would pass the newer object to be processed as a delete when there was an update to its status to indicate the object was complete. In the pod deletion path there is another check for podCompleted. This check will fail on the older object, so we need to pass the new which will include the the terminal status as well as latest ovnk annotations on the object. Signed-off-by: Tim Rozet <trozet@redhat.com> (cherry picked from commit 4ceb0ae)
The pods were being incorrectly created with the expected IP already present in pod status field...before it was ever even allocated by OVNK. This would cause the tests to function incorrectly as OVNK checks this field to know whether or not it is safe to deallocate IPs (in case any other pod has a duplicate IP). Signed-off-by: Tim Rozet <trozet@redhat.com> (cherry picked from commit 2a17c21)
openshift-ci
bot
added
bugzilla/severity-high
|
@trozet: This pull request references Bugzilla bug 2100220, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci
bot
added
approved
|
@trozet: This pull request references Bugzilla bug 2100220, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ricky-rav, trozet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold Revision 1b4e65f was retested 9 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
|
/retest-required |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@trozet: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@trozet: All pull requests linked via external trackers have merged: Bugzilla bug 2100220 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.11 |
|
@tssurya: new pull request created: #1176 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Clean backport from upstream