Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.8] Bug OCPBUGS-1793: EgressGW: don't error out trying to add SPK when a pod without ip exists #1283

Merged
merged 1 commit into from Jan 31, 2023
Merged

[release-4.8] Bug OCPBUGS-1793: EgressGW: don't error out trying to add SPK when a pod without ip exists #1283

merged 1 commit into from Jan 31, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1252

/assign oribon

@oribon
EgressGW: don't error out trying to add SPK when a pod without ip exists
a0fe771 
When the SPK is added and is serving an ICNI namespace, we will search all of the pods in the served namespace to update their routes to point to this new SPK.
If for some reason one of the pods in the namespace has no IPs, we error out trying to add the SPK.
The correct behavior should just be to warn that the pod IPs are missing and continue with adding the SPK.

Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 28, 2022
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-574 has been cloned as Jira Issue OCPBUGS-1793. Retitling PR to link against new bug.
/retitle [release-4.8] Bug OCPBUGS-1793: EgressGW: don't error out trying to add SPK when a pod without ip exists

In response to this:

This is an automated cherry-pick of #1252

/assign oribon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.8] Bug OCPBUGS-574: EgressGW: don't error out trying to add SPK when a pod without ip exists [release-4.8] Bug OCPBUGS-1793: EgressGW: don't error out trying to add SPK when a pod without ip exists Sep 28, 2022
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: An error was encountered converting bugzilla URL to an ID for bug OCPBUGS-1793 on the Jira server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. strconv.Atoi: parsing "": invalid syntax

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

This is an automated cherry-pick of #1252

/assign oribon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 28, 2022

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.8] Bug OCPBUGS-1793: EgressGW: don't error out trying to add SPK when a pod without ip exists

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oribon
Copy link
Contributor

oribon commented Sep 28, 2022

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@oribon: An error was encountered converting bugzilla URL to an ID for bug OCPBUGS-1793 on the Jira server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. strconv.Atoi: parsing "": invalid syntax

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oribon
Copy link
Contributor

oribon commented Oct 18, 2022

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 18, 2022
@openshift-ci-robot
Copy link
Contributor

@oribon: This pull request references Jira Issue OCPBUGS-1793, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.8.z) matches configured target version for branch (4.8.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-574 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-574 targets the "4.9.z" version, which is one of the valid target versions: 4.9.0, 4.9.z
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 18, 2022
trozet
trozet approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@trozet trozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label backport-risk-assessed

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 20, 2022
@trozet
Copy link
Contributor

trozet commented Oct 30, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@trozet
Copy link
Contributor

trozet commented Oct 30, 2022

/assign @anuragthehatter

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 29, 2023
@oribon
Copy link
Contributor

oribon commented Jan 30, 2023

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 30, 2023
@anuragthehatter
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 30, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 0b69324 and 2 for PR HEAD a0fe771 in total

@oribon
Copy link
Contributor

oribon commented Jan 31, 2023

/retest-required

1 similar comment
@oribon
Copy link
Contributor

oribon commented Jan 31, 2023

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 31, 2023 •
edited

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.8-upgrade-from-stable-4.7-e2e-aws-ovn-upgrade a0fe771 link false /test 4.8-upgrade-from-stable-4.7-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oribon
Copy link
Contributor

oribon commented Jan 31, 2023

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit 57259fe into openshift:release-4.8 Jan 31, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-1793 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #1252

/assign oribon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trozet trozet trozet approved these changes

@abhat abhat Awaiting requested review from abhat

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

Assignees

@trozet trozet

@anuragthehatter anuragthehatter

@oribon oribon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@openshift-cherrypick-robot @openshift-ci-robot @oribon @trozet @openshift-bot @anuragthehatter @openshift-merge-robot