OCPBUGS-2176: add endpointSlice informer in master process #1302
Conversation
Signed-off-by: Zenghui Shi <zshi@redhat.com> (cherry picked from commit b6c1b08)
zshi-redhat
changed the title
openshift-ci-robot
added
jira/severity-critical
|
@zshi-redhat: This pull request references Jira Issue OCPBUGS-2176, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
|
@zshi-redhat: This pull request references Jira Issue OCPBUGS-2176, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
1 similar comment
|
/retest |
|
@zshi-redhat can you explain a bit why we need this in the commit message or PR message or the bug? There is no info anywhere. Might be obvious for some but not all. |
|
@zshi-redhat: This pull request references Jira Issue OCPBUGS-2176, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jcaamano sure, I updated the PR message. |
|
@zshi-redhat: This pull request references Jira Issue OCPBUGS-2176, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcaamano, zshi-redhat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@zshi-redhat: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required |
|
@zshi-redhat: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-2176 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In MicroShift, ovnkube-master and ovnkube-node run in a single process/container
which acts as both master and node roles. The NewMasterWatchFactory needs to
initialize a new watch factory for both, otherwise it results in panic watching
endpointSlice which only existed in node watch factory.
This PR creates endpointSlices in master watch factory even it is not used when
master and node are deployed separately, this will be fixed by upstream PR:
ovn-org/ovn-kubernetes#3193.
Signed-off-by: Zenghui Shi zshi@redhat.com
(cherry picked from commit b6c1b08)