OCPBUGS-3614: [4.11] CARRY: client: don't construct transaction log string when it's not needed

[dcbw]

Backport of ovn-org/libovsdb#342 (see also 4.12 version #1348)

fmt.Sprintf() will be evaluated before the logging function is called, which means that even if the logging level is less than V(4) we'll still construct the whole string for the operation, just to discard it. That can be pretty expensive.

[openshift-ci]

@dcbw: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

CARRY: client: don't construct transaction log string when it's not needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@dcbw: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-3614: CARRY: client: don't construct transaction log string when it's not needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@dcbw: This pull request references Jira Issue OCPBUGS-3614, which is invalid:

• expected dependent Jira Issue OCPBUGS-3346 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Backport of ovn-org/libovsdb#342 (see also 4.12 version #1348)

fmt.Sprintf() will be evaluated before the logging function is called, which means that even if the logging level is less than V(4) we'll still construct the whole string for the operation, just to discard it. That can be pretty expensive.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@dcbw: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-3614: [4.11] CARRY: client: don't construct transaction log string when it's not needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jcaamano]

@dcbw why not bump it it like in 4.12?

[dcbw]

/retest

[dcbw]

@dcbw why not bump it it like in 4.12?

@jcaamano sure, looking at the diff we could do that. Delta is pretty small and well-contained.

[dcbw]

@jcaamano did the revendor, PTAL thanks!

[dcbw]

/retest

[jcaamano]

/lgtm
/label backport-risk-assessed

[dcbw]

/jira refresh

[openshift-ci-robot]

@dcbw: This pull request references Jira Issue OCPBUGS-3614, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.11.z) matches configured target version for branch (4.11.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-3346 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
• dependent Jira Issue OCPBUGS-3346 targets the "4.12.0" version, which is one of the valid target versions: 4.12.0
• bug has dependents

Requesting review from QA contact:
/cc @mffiedler

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jcaamano]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, jcaamano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dcbw,jcaamano]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dcbw]

/retest-required

[dcbw]

/test 4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade

[dcbw]

/test e2e-aws-ovn-local-to-shared-gateway-mode-migration

[mffiedler]

/label cherry-pick-approved

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 54d844f and 2 for PR HEAD 3e896a2 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD fbc34a5 and 1 for PR HEAD 3e896a2 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD cf1c37f and 0 for PR HEAD 3e896a2 in total

[openshift-ci-robot]

/hold

Revision 3e896a2 was retested 3 times: holding

[dcbw]

/hold cancel
/override ci/prow/e2e-metal-ipi-ovn-dualstack
https://coreos.slack.com/archives/CFP6ST0A3/p1670860628776879

[openshift-ci]

@dcbw: Overrode contexts on behalf of dcbw: ci/prow/e2e-metal-ipi-ovn-dualstack

In response to this:

/hold cancel
/override ci/prow/e2e-metal-ipi-ovn-dualstack
https://coreos.slack.com/archives/CFP6ST0A3/p1670860628776879

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dcbw]

/override ci/prow/e2e-aws-ovn-upgrade

not a network thing

ns/openshift-etcd pod/etcd-ip-10-0-220-163.ec2.internal node/ip-10-0-220-163.ec2.internal - 3478.73 seconds after deletion - reason/FailedCreatePodSandBox Failed to create pod sandbox: rpc error: code = Unknown desc = create dropped infra 3740280ad77f34e75cd12c85cd12f00ebc76daaa83e2a1d92e297cb656ab30bc cgroup: error creating cgroup path for devices: mkdir /sys/fs/cgroup/devices/kubepods.slice/kubepods-burstable.slice/kubepods-burstable-pod871de77c2dc84506b1b76d91beb065d1.slice: no such file or directory}

[openshift-ci]

@dcbw: Overrode contexts on behalf of dcbw: ci/prow/e2e-aws-ovn-upgrade

In response to this:

/override ci/prow/e2e-aws-ovn-upgrade

not a network thing

ns/openshift-etcd pod/etcd-ip-10-0-220-163.ec2.internal node/ip-10-0-220-163.ec2.internal - 3478.73 seconds after deletion - reason/FailedCreatePodSandBox Failed to create pod sandbox: rpc error: code = Unknown desc = create dropped infra 3740280ad77f34e75cd12c85cd12f00ebc76daaa83e2a1d92e297cb656ab30bc cgroup: error creating cgroup path for devices: mkdir /sys/fs/cgroup/devices/kubepods.slice/kubepods-burstable.slice/kubepods-burstable-pod871de77c2dc84506b1b76d91beb065d1.slice: no such file or directory}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@dcbw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure-ovn	3e896a2	link	false	/test e2e-azure-ovn
ci/prow/e2e-vsphere-ovn	3e896a2	link	false	/test e2e-vsphere-ovn
ci/prow/e2e-hypershift	3e896a2	link	false	/test e2e-hypershift
ci/prow/e2e-aws-ovn-serial	3e896a2	link	false	/test e2e-aws-ovn-serial
ci/prow/e2e-metal-ipi-ovn-dualstack	3e896a2	link	true	/test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-aws-ovn-upgrade	3e896a2	link	unknown	/test e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@dcbw: All pull requests linked via external trackers have merged:

• openshift/ovn-kubernetes#1374

Jira Issue OCPBUGS-3614 has been moved to the MODIFIED state.

In response to this:

Backport of ovn-org/libovsdb#342 (see also 4.12 version #1348)

fmt.Sprintf() will be evaluated before the logging function is called, which means that even if the logging level is less than V(4) we'll still construct the whole string for the operation, just to discard it. That can be pretty expensive.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.