Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.11] OCPBUGS-2554: Fix UpdateService healthport checks #1389

Merged
merged 1 commit into from Nov 30, 2022
Merged

[release-4.11] OCPBUGS-2554: Fix UpdateService healthport checks #1389

merged 1 commit into from Nov 30, 2022

Conversation

msherif1234
Copy link
Contributor

We were not creating healthchecks for service updates when the etp changed from local to cluster or back. This PR fixes this.

Signed-off-by: Surya Seetharaman suryaseetharaman.9@gmail.com
(cherry picked from commit 4c7add6)

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

@tssurya @msherif1234
Fix UpdateService healthport checks
5464286 
We were not creating healthchecks for service updates
when the etp changed from local to cluster or back. This
PR fixes this. It also fixes some endpoint slices code
that earlier assumed svc:endpointslice was 1:1 mapping.

Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
(cherry picked from commit 4c7add6)
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 21, 2022

@msherif1234: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.11] OCPBUGS-2554: Fix UpdateService healthport checks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@msherif1234: This pull request references Jira Issue OCPBUGS-2554, which is invalid:

  • expected the bug to target the "4.11.z" version, but no target version was set
  • expected Jira Issue OCPBUGS-2554 to depend on a bug targeting a version in 4.12.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

We were not creating healthchecks for service updates when the etp changed from local to cluster or back. This PR fixes this.

Signed-off-by: Surya Seetharaman suryaseetharaman.9@gmail.com
(cherry picked from commit 4c7add6)

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from dcbw and tssurya November 21, 2022 13:37
@msherif1234
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@msherif1234: This pull request references Jira Issue OCPBUGS-2554, which is invalid:

  • expected the bug to target the "4.11.z" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@msherif1234
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 21, 2022
@openshift-ci-robot
Copy link
Contributor

@msherif1234: This pull request references Jira Issue OCPBUGS-2554, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.11.z) matches configured target version for branch (4.11.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-3003 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-3003 targets the "4.12.0" version, which is one of the valid target versions: 4.12.0
  • bug has dependents

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@msherif1234
Copy link
Contributor Author

/retest-required

2 similar comments
@msherif1234
Copy link
Contributor Author

/retest-required

@msherif1234
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 22, 2022

@msherif1234: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ovn-hybrid-step-registry 5464286 link false /test e2e-ovn-hybrid-step-registry
ci/prow/e2e-openstack-ovn 5464286 link false /test e2e-openstack-ovn
ci/prow/e2e-azure-ovn 5464286 link false /test e2e-azure-ovn
ci/prow/e2e-hypershift 5464286 link false /test e2e-hypershift
ci/prow/e2e-aws-ovn-serial 5464286 link false /test e2e-aws-ovn-serial
ci/prow/4.11-upgrade-from-stable-4.10-local-gateway-e2e-aws-ovn-upgrade 5464286 link false /test 4.11-upgrade-from-stable-4.10-local-gateway-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tssurya
Copy link
Contributor

tssurya commented Nov 23, 2022

/lgtm
thanks @msherif1234 .
With regards to the original PR, the other bits were to fix the endpoint slice issues around count. This PR is bringing in whatever is needed for 4.11.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2022
@msherif1234
Copy link
Contributor Author

/assign @jcaamano pls add all required tags Thanks!

trozet
trozet approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@trozet trozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 29, 2022
@trozet
Copy link
Contributor

trozet commented Nov 29, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234, trozet, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234, trozet, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mffiedler
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 30, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 6b825fe and 2 for PR HEAD 5464286 in total

@openshift-merge-robot openshift-merge-robot merged commit 81a0fe3 into openshift:release-4.11 Nov 30, 2022
@openshift-ci-robot
Copy link
Contributor

@msherif1234: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-2554 has been moved to the MODIFIED state.

In response to this:

We were not creating healthchecks for service updates when the etp changed from local to cluster or back. This PR fixes this.

Signed-off-by: Surya Seetharaman suryaseetharaman.9@gmail.com
(cherry picked from commit 4c7add6)

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trozet trozet trozet approved these changes

@dcbw dcbw Awaiting requested review from dcbw

@tssurya tssurya Awaiting requested review from tssurya

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@tssurya tssurya

@weliang1 weliang1

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@yingwang-0320 yingwang-0320

@qiowang721 qiowang721

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet