Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream merge 2020-04-15 #139

Merged
merged 25 commits into from Apr 16, 2020

Conversation

dcbw
Copy link
Member

@dcbw dcbw commented Apr 15, 2020

Brings in Dan's dual-stack work so far.

Pardhakeswar and others added 25 commits April 9, 2020 22:25
Currently, sed command is used to generate the ovn-setup.yaml
from ovn-setup.yaml.j2. Instead, j2 tool is used to generate the yaml
file for ovn-setup.yaml.

Signed-off-by: Pardhakeswar Pacha <ppacha@nvidia.com>
Signed-off-by: Dan Winship <danw@redhat.com>
Also make the caller set the chassis ID explicitly (like it was
originally), for consistency on set vs get.

Signed-off-by: Dan Winship <danw@redhat.com>
go1.13 is required for this version of k8s

Signed-off-by: Tim Rozet <trozet@redhat.com>
Signed-off-by: Dan Winship <danw@redhat.com>
dual-stack support for l3-gateway-config annotation
daemonset.sh: Using j2 tool to generate ovn-setup.yaml file.
Signed-off-by: Dan Winship <danw@redhat.com>
(It is currently still always called with a single hostsubnet though
since the hostsubnet annotation hasn't been made dual-stack yet.)

Signed-off-by: Dan Winship <danw@redhat.com>
Put the test name earlier since the GitHub Actions UI only shows
the first 24 characters or so.

Signed-off-by: Dan Williams <dcbw@redhat.com>
It's already defined as KIND_CLUSTER_NAME in the github workflow,
so might as well use that.

Signed-off-by: Dan Williams <dcbw@redhat.com>
kubetest's Kind integration doesn't seem to play very well with
our kind setup. For example it doesn't find our existing kind
binary and downloads one of its own. Just run the e2e tests
directly since we don't need any kind of cloud provider
integration that kubetest offers.

Signed-off-by: Dan Williams <dcbw@redhat.com>
Sometimes e2e KIND setup will fail with:

+ kubectl -n kube-system delete ds kube-proxydaemonset.apps
"kube-proxy" deleted
Error from server: rpc error: code = Unavailable desc = etcdserver: leader changed

Try a couple times hoping things won't continuously fail.

Signed-off-by: Dan Williams <dcbw@redhat.com>
These were already indirectly tested by pkg/ovn/master_test.go, but
let's test them directly too.

Signed-off-by: Dan Winship <danw@redhat.com>
Signed-off-by: Dan Winship <danw@redhat.com>
Signed-off-by: Dan Winship <danw@redhat.com>
ci: various cleanups and stop using kubetest
Fixes: 3677530 (ovn: remove gratuitous string/IPNet conversions
around subnet allocation)

Signed-off-by: Girish Moodalbail <gmoodalbail@nvidia.com>
regression: fix nil-pointer reference panic in defer function
…nt-port

dual stack management port creation
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2020
@openshift-ci-robot
Copy link
Contributor

@dcbw: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-ovn c1a77d3 link /test e2e-gcp-ovn
ci/prow/e2e-metal-ipi c1a77d3 link /test e2e-metal-ipi

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rcarrillocruz
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, rcarrillocruz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2020
@openshift-merge-robot openshift-merge-robot merged commit eadc1f9 into openshift:master Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants