Bug 1828988: Remove errors based on passing nil elements to MarshalPodAnnotations() #156
Conversation
Currently passing nil elements to MarshalPodAnnotations will cause "<nil>" to be added to the json fields where they are not appropriate. This PR removes one specific example of attempting to pass a nil element to MarshalPodAnnotations() and fixes an error in UnmarshalPodAnnotations() which incorrectly handled a call to net.ParseIP() in which was expecting an error in the case of an invalid IP address but in the docs returns nil on invalid IP. This exposes the error of attempting to unmarshal an invaild gatewayIP and add a test case to verify the error returned. Signed-off-by: Jacob Tanenbaum <jtanenba@redhat.com>
openshift-ci-robot
added
the
bugzilla/severity-medium
|
@JacobTanenbaum: This pull request references Bugzilla bug 1828988, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
Pull Request Test Coverage Report for Build 97377352
💛 - Coveralls |
|
/bugzilla refresh |
|
@JacobTanenbaum: This pull request references Bugzilla bug 1828988, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/valid-bug
|
@JacobTanenbaum: This pull request references Bugzilla bug 1828988, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
1 similar comment
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dcbw, JacobTanenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@JacobTanenbaum: All pull requests linked via external trackers have merged: openshift/ovn-kubernetes#156. Bugzilla bug 1828988 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cherry pick of upstream: b5fb5b
Currently passing nil elements to MarshalPodAnnotations will cause ""
to be added to the json fields where they are not appropriate.
This PR removes one specific example of attempting to pass a nil element
to MarshalPodAnnotations() and fixes an error in UnmarshalPodAnnotations()
which incorrectly handled a call to net.ParseIP() in which was expecting
an error in the case of an invalid IP address but in the docs returns nil
on invalid IP. This exposes the error of attempting to unmarshal an
invaild gatewayIP and add a test case to verify the error returned.
Signed-off-by: Jacob Tanenbaum jtanenba@redhat.com