Bug 1828752: regression: logical_router_port mac address is case sensitive #163
Conversation
when we moved all the MAC address from string to net.HardwareAddr it had a side effect. the String() function of that struct always returns the MAC address with lower case letters. however, before that move the MAC addresses were all upper case. so, when you upgrade a cluster to the latest ovn-k8s code the ovnkube-master doesn't come up and errors out with the following error -----8<------ port already exists with mac 0A:58:64:40:8B:09\n", error: OVN command '/usr/bin/ovn-nbctl lrp-add GR_node1 rtoj-GR_node1 0a:58:64:40:8b:09 100.64.139.9/29' -----8<------ this commit, for short term, deletes the logical router port and adds it back so that all the ports going forward will have MAC address that has lower case letters. upon upgrading a cluster to this commit ovnkube-master will delete the the existing port with upper case MAC address and add it back with lower case MAC address. on subsequent restarts of the ovnkube-master, the lrp-del followed by lrp-add will be a no-op. eventually, we can remove this commit. Signed-off-by: Girish Moodalbail <gmoodalbail@nvidia.com>
openshift-ci-robot
added
bugzilla/severity-urgent
|
@danwinship: This pull request references Bugzilla bug 1828752, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
|
/cc @dcbw |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, dcbw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@danwinship: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
sdodson
added
the
cherry-pick-approved
|
@danwinship: All pull requests linked via external trackers have merged: openshift/ovn-kubernetes#163. Bugzilla bug 1828752 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
backports the fix for MAC address case-sensitivity, fixing 4.3→4.4 upgrades (including for OKD)