OCPBUGS-14769,SDN-3885: Downstream Merge 13th June 2023 #1707
Conversation
Users can create the external gateway bridge without attaching a host physical interface as the uplink port in local gateway mode. The gateway router will use 169.254.169.4 as the default gateway. Add a new gateway config flag 'allow-no-uplink' to controll if this setup is allowed or not. It's disabled by default. With this setup, egressIP and egressGW can not work. Signed-off-by: Peng Liu <pliu@redhat.com> (cherry picked from commit 89f953d)
Signed-off-by: Peng Liu <pliu@redhat.com> (cherry picked from commit e80027a)
For services and endpoints, make sure that the protocol and port are valid before deleting conntrack flows. Under certain circumstances, the port may be the default value (meaning 0), indicating that all conntrack flows for a given IP shall be deleted. However, for endpoints and services, only ever delete exact matches. Otherwise, ovnkube-node might remove conntrack flows inserted by unrelated components (such as iptables rules). If for any reason protocol is invalid, skip conntrack deletion instead. Reported-at: https://issues.redhat.com/browse/OCPBUGS-14769 Signed-off-by: Andreas Karis <ak.karis@gmail.com>
openshift-ci-robot
added
jira/severity-important
|
@tssurya: This pull request references Jira Issue OCPBUGS-14769, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. This pull request references SDN-3885 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
requested review from
anuragthehatter,
abhat and
JacobTanenbaum
|
@tssurya: This pull request references Jira Issue OCPBUGS-14769, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: This pull request references SDN-3885 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
lgtm for my commit as soon as upstream merges. NIT: "Validate port before deleting conntrack flow" wasn't cherry-picked with |
it was but since its not merged it wasn't found in any tree... so couldn't do it that way :) |
|
/payload 4.14 nightly blocking |
|
@tssurya: trigger 7 job(s) of type blocking for the nightly release of OCP 4.14
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/048732b0-09d4-11ee-9fef-9ca7b2a00a5e-0 |
|
/payload 4.14 ci blocking |
|
@tssurya: trigger 4 job(s) of type blocking for the ci release of OCP 4.14
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/12b25d60-09d4-11ee-91d3-8acb156de6f2-0 |
|
/retest-required |
|
/payload-aggregate periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade 10 |
|
@tssurya: trigger 1 job(s) for the /payload-(job|aggregate) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/71f5d720-09ed-11ee-94bd-2402d6917c25-0 |
|
/override ci/prow/e2e-aws-ovn-upgrade-local-gateway |
|
@trozet: Overrode contexts on behalf of trozet: ci/prow/e2e-aws-ovn-upgrade-local-gateway In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: trozet, tssurya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/payload-aggregate periodic-ci-openshift-release-master-ci-4.14-e2e-azure-ovn-upgrade 10 |
|
@tssurya: trigger 2 job(s) for the /payload-(job|aggregate) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f20fff70-0a20-11ee-8dfc-81f7574ff818-0 |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/override ci/prow/e2e-aws-ovn-upgrade-local-gateway |
|
/retest-required |
|
@trozet: Overrode contexts on behalf of trozet: ci/prow/e2e-aws-ovn-upgrade-local-gateway In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required |
|
/override ci/prow/e2e-aws-ovn-upgrade-local-gateway |
|
@trozet: Overrode contexts on behalf of trozet: ci/prow/e2e-aws-ovn-upgrade-local-gateway In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@tssurya: Jira Issue OCPBUGS-14769: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-14769 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@tssurya: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This brings in two critical fixes:
https://issues.redhat.com/browse/SDN-3885 cc @pliurh
and a high priority bug fix: https://issues.redhat.com/browse/OCPBUGS-14769
NO CONFLICTS, CLEAN CHERRY-PICKs
/cc @trozet @pliurh @andreaskaris