Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-14982: Validate port before deleting conntrack flow #1713

Merged
merged 1 commit into from Jun 23, 2023
Merged

OCPBUGS-14982: Validate port before deleting conntrack flow #1713

merged 1 commit into from Jun 23, 2023

Conversation

abhat
Copy link
Contributor

@abhat abhat commented Jun 16, 2023

For services and endpoints, make sure that the protocol and port are valid before deleting conntrack flows.
Under certain circumstances, the port may be the default value (meaning 0), indicating that all conntrack flows for a given IP shall be deleted. However, for endpoints and services, only ever delete exact matches. Otherwise, ovnkube-node might remove conntrack flows inserted by unrelated components (such as iptables rules). If for any reason protocol is invalid, skip conntrack deletion instead.

Reported-at: https://issues.redhat.com/browse/OCPBUGS-14769
Signed-off-by: Andreas Karis ak.karis@gmail.com
(cherry picked from commit eacdaa7)

@andreaskaris @abhat
Validate port before deleting conntrack flow
c8c3396 
For services and endpoints, make sure that the protocol and port are
valid before deleting conntrack flows.
Under certain circumstances, the port may be the default value
(meaning 0), indicating that all conntrack flows for a given IP shall
be deleted. However, for endpoints and services, only ever delete
exact matches. Otherwise, ovnkube-node might remove conntrack flows
inserted by unrelated components (such as iptables rules).
If for any reason protocol is invalid, skip conntrack deletion instead.

Reported-at: https://issues.redhat.com/browse/OCPBUGS-14769
Signed-off-by: Andreas Karis <ak.karis@gmail.com>
(cherry picked from commit eacdaa7)
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 16, 2023
@openshift-ci-robot
Copy link
Contributor

@abhat: This pull request references Jira Issue OCPBUGS-14982, which is invalid:

  • expected Jira Issue OCPBUGS-14982 to depend on a bug targeting a version in 4.13.0, 4.13.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

For services and endpoints, make sure that the protocol and port are valid before deleting conntrack flows.
Under certain circumstances, the port may be the default value (meaning 0), indicating that all conntrack flows for a given IP shall be deleted. However, for endpoints and services, only ever delete exact matches. Otherwise, ovnkube-node might remove conntrack flows inserted by unrelated components (such as iptables rules). If for any reason protocol is invalid, skip conntrack deletion instead.

Reported-at: https://issues.redhat.com/browse/OCPBUGS-14769
Signed-off-by: Andreas Karis ak.karis@gmail.com
(cherry picked from commit eacdaa7)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhat
Copy link
Contributor Author

abhat commented Jun 16, 2023

/assign @tssurya @trozet

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2023
tssurya
tssurya reviewed Jun 16, 2023
View reviewed changes
Copy link
Contributor

@tssurya tssurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Leaving approval to tim since its not clean pick.

@trozet
Copy link
Contributor

trozet commented Jun 16, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 16, 2023
@trozet
Copy link
Contributor

trozet commented Jun 16, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhat, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@asood-rh
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 16, 2023
@dcbw
Copy link
Contributor

dcbw commented Jun 20, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@dcbw: This pull request references Jira Issue OCPBUGS-14982, which is invalid:

  • expected dependent Jira Issue OCPBUGS-14979 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Contributor

dcbw commented Jun 22, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 22, 2023
@openshift-ci-robot
Copy link
Contributor

@dcbw: This pull request references Jira Issue OCPBUGS-14982, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-14979 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-14979 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

Requesting review from QA contact:
/cc @asood-rh

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from asood-rh June 22, 2023 17:45
@dcbw
Copy link
Contributor

dcbw commented Jun 22, 2023

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 48c7db9 and 2 for PR HEAD c8c3396 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2023 •
edited

@abhat: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn c8c3396 link false /test e2e-azure-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhat
Copy link
Contributor Author

abhat commented Jun 23, 2023

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit 17f9ed5 into openshift:release-4.12 Jun 23, 2023
25 of 26 checks passed
@openshift-ci-robot
Copy link
Contributor

@abhat: Jira Issue OCPBUGS-14982: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-14982 has been moved to the MODIFIED state.

In response to this:

For services and endpoints, make sure that the protocol and port are valid before deleting conntrack flows.
Under certain circumstances, the port may be the default value (meaning 0), indicating that all conntrack flows for a given IP shall be deleted. However, for endpoints and services, only ever delete exact matches. Otherwise, ovnkube-node might remove conntrack flows inserted by unrelated components (such as iptables rules). If for any reason protocol is invalid, skip conntrack deletion instead.

Reported-at: https://issues.redhat.com/browse/OCPBUGS-14769
Signed-off-by: Andreas Karis ak.karis@gmail.com
(cherry picked from commit eacdaa7)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tssurya tssurya tssurya left review comments

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

@trozet trozet Awaiting requested review from trozet

@asood-rh asood-rh Awaiting requested review from asood-rh

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@tssurya tssurya

@trozet trozet

@weliang1 weliang1

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@qiowang721 qiowang721

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet