OCPBUGS-15227: [DownstreamMerge] 6-21-23 #1718
Conversation
Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
Now that we support separated Network and LoadBalancer SNAT behavior, the clustermanager controller does not need to allocate any node for the Service as each pod should exit from its node. It should react to EgressServices with SourceIPBy != "LoadBalancerIP" by marking their host as "ALL" and cleaning any existing allocations they have. Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
When the EgressService has a host="ALL" as a result of the clustermanager detecting SourceIPBy != "LoadBalancerIP" the zone controller should not manage any OVN objects as each pod should exit its own node. Thus when it detects a host="ALL" EgressService it should remove all existing configuration. Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
When the host of the EgressService is "ALL" each pod exits from its own node, thus ovnkube-node needs to create ip rules only for the endpoints local to it. Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
* Configure the tests to use the new CRD model with separated Network and SNAT. * Add a test for multiple external clients on different networks sharing the same I while configuring Network without SNAT, mimicking the scenario of multiple VRFs. Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
Make sure the egress-service labels of the node match only the services allocated to it. Up until now we only added and deleted labels according to our caches, but we didn't handle the situation where a label that does not belong to the node appears on it (e.g by a user adding it manually). Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
When an EgressIP gets created with an IP address that is already used by a different object ovn-kubernetes should emit a warning event. Signed-off-by: Patryk Diak <pdiak@redhat.com>
EgressService: Seperate Network and SNAT
Emit a warning event for duplicated egress IPs
…s inside go-controller/pkg/crd/ to avoid unwanted errors due to invalid formatting Signed-off-by: jordigilh <jgil@redhat.com>
Disable gofmt check for register.go and factory.go CRD autogenerated files
This test adds 2 legacy hybrid routes in the old format and then 1 new one and runs the stale cleanup code to verify that legacy ones get removed. By starting APB controller it will also try to run repair and potentially remove the new one becuase it does not match a real pod in the cluster. There is no real value in having APB in this test. Signed-off-by: Tim Rozet <trozet@redhat.com>
We were not actually waiting for the informer cache to sync before starting workers. Signed-off-by: Tim Rozet <trozet@redhat.com>
Leftover from testing probably. Signed-off-by: Tim Rozet <trozet@redhat.com>
2023-06-21T01:32:41.27224837Z stderr F E0621 01:32:41.272153 1616 runtime.go:79] Observed a panic: "assignment to entry in nil map" (assignment to entry in nil map)
2023-06-21T01:32:41.27226207Z stderr F goroutine 447 [running]:
2023-06-21T01:32:41.27226607Z stderr F k8s.io/apimachinery/pkg/util/runtime.logPanic({0x1d7d920?, 0x23d56b0})
2023-06-21T01:32:41.27226907Z stderr F /home/runner/work/ovn-kubernetes/ovn-kubernetes/go-controller/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:75 +0x99
2023-06-21T01:32:41.27228377Z stderr F k8s.io/apimachinery/pkg/util/runtime.HandleCrash({0x0, 0x0, 0xc000260000?})
2023-06-21T01:32:41.27228707Z stderr F /home/runner/work/ovn-kubernetes/ovn-kubernetes/go-controller/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:49 +0x75
2023-06-21T01:32:41.27229307Z stderr F panic({0x1d7d920, 0x23d56b0})
2023-06-21T01:32:41.27229617Z stderr F /opt/hostedtoolcache/go/1.19.6/x64/src/runtime/panic.go:884 +0x212
2023-06-21T01:32:41.27229937Z stderr F k8s.io/apimachinery/pkg/util/sets.Set[...].Insert(0x15?, {0xc00062dd20?, 0x2?, 0x0})
2023-06-21T01:32:41.272317871Z stderr F /home/runner/work/ovn-kubernetes/ovn-kubernetes/go-controller/vendor/k8s.io/apimachinery/pkg/util/sets/set.go:50 +0x6a
2023-06-21T01:32:41.272322071Z stderr F github.com/ovn-org/ovn-kubernetes/go-controller/pkg/node.(*DefaultNodeNetworkController).syncConntrackForExternalGateways(0xc000f7c2a0, 0xc001678c60)
Signed-off-by: Tim Rozet <trozet@redhat.com>
Signed-off-by: Patryk Diak <pdiak@redhat.com>
Fix apb informer sync wait
Fixes race in delete legacy hybrid route policies
Fixes panic with APB sync conntrack
Signed-off-by: jordigilh <jgil@redhat.com>
…Delete and onUpdate Signed-off-by: jordigilh <jgil@redhat.com>
EgressIP: do not patch the status if the object no longer exists
…ng_pod Adds cast check when getting object from queue in APB logic
openshift-ci-robot
added
jira/severity-moderate
|
@trozet: This pull request references Jira Issue OCPBUGS-15227, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
jira/invalid-bug
openshift-ci
bot
added
the
approved
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@trozet: This pull request references Jira Issue OCPBUGS-15227, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/test e2e-aws-ovn-serial |
|
/override ci/prow/e2e-aws-ovn-upgrade-local-gateway |
|
@trozet: Overrode contexts on behalf of trozet: ci/prow/e2e-aws-ovn-upgrade-local-gateway In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bpickard22, trozet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@trozet: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@trozet: Jira Issue OCPBUGS-15227: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-15227 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Pulls in egress service features and APB fixes
@oribon @jordigilh