SDN-3732,SDN-3733,OCPBUGS-12747,OCPBUGS-16413,OCPBUGS-10650: [DownstreamMerge] 7-19-23 #1750
Conversation
|
/retest |
Signed-off-by: Andreas Karis <ak.karis@gmail.com>
This reverts commit 926a1dc. Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
This commit ensures egress ip status is in sync with cloud private ip config on a restarted ovnk master because stale entry is noticed in the egress ip status though cloud private ip config entry is not present for the given egress ip. This might have happened while processing cloud private ip config delete event, an error is thrown because of bug fixed in PR#3371. Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
This changes to use CloudPrivateIPConfig sync function to remove stale egress ip status and also uses informer cache to retrieve objects instead of invoking api server. Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
This adds unit test to validate egress ip status when there is no cloud private ip config objects present during cluster manager restart scenarios. Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
this was caught in review for the PR to rebase to k8s 1.27 [0] but the PR was approved and merged before it could be updated. [0] https://github.com/ovn-org/ovn-kubernetes/pull/3593/files/2c4701d8e2ac5326affe0fc39f97f8fefb71e437..3ce2d31065684edc4607be3b51b1754867c71ebf#top Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
and races with namespace and pod handlers. For cache fix, add routePolicySyncCache that stores the lates state for every target pod, and allows retries. For races add policyReferencedObjects cache to allow policy handler share the references objects it used for the latest config. Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
Now repair will initialize policies cache by handling every existing policy, and return existing routes for future cleanup. Make sure Repair can return error, because if it fails, some stale routes may be left in the system, and it can't be fixed by any controller. Fix buildExternalIPGatewaysFromAnnotations function to only set dynamic gateway ips for pod in the target namespace instead of all pods. Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
for ip without double quotes, the following error occurred:
unable to unmarshall annotation on pod e2e-gateway-pod1
k8s.v1.cni.cncf.io/network-status '[{"name":"foo","interface":"net1",
"ips":[172.18.0.5],"mac":"01:23:45:67:89:10"}]': invalid character '.'
after array element
that caused all reconciliation on apb route and external gateway side to
fail because they couldn't extract ip for pod.
checkAPBExternalRouteStatus call should help in that case to signal that
no errors occurred (especially when we expect config to stay the same)
Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
gateway pod ip should be cleaned up. Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
It used to fail parsing namespace annotations, because they were empty. Add RunAPBExternalPolicyController call to handle apbroutes. Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
db state, simplify policy creation. Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
init. Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
[error]Artifact path is not valid: /ovn-control-plane/e2e-dbs/should_provide_Internet_connection_continuously_when_pod_running_master_instance_of_ovnkube-control-plane_is_killed"-nettest-9947/ovn-control-plane-conf.db. Contains the following character: Double quote " Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
Changes-Include: - On pod add/update the IP not might be available yet, since another node might be allocating its IP. Suppress the error. - Warning was printing a wrapped error object - On completed pods check, if the pod had no IP, it would cause an error and be retried. If the pod is completed and has no IP, we should not retry or log error. Signed-off-by: Tim Rozet <trozet@redhat.com>
Handle pod IPs correctly for address set selector
use false in OnAdd in WithUpdateHandlingForObjReplace
Add mlb entry to kind.sh --help
Signed-off-by: haojue <acewhj@gmail.com>
pperiyasamy
force-pushed
the
stale-egressip-status
branch
from
38470c8
to
9c1fe19
Compare
pperiyasamy
changed the title
pperiyasamy
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@pperiyasamy: This pull request references SDN-3733 which is a valid jira issue. This pull request references Jira Issue OCPBUGS-12747, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jechen@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pperiyasamy
changed the title
|
@pperiyasamy: This pull request references SDN-3733 which is a valid jira issue. This pull request references Jira Issue OCPBUGS-12747, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jechen@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-16413, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jechen@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pperiyasamy
changed the title
|
@pperiyasamy: This pull request references SDN-3733 which is a valid jira issue. This pull request references Jira Issue OCPBUGS-12747, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jechen@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-16413, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jechen@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-10650, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This is closing SDN-3732 too, can we modify the description ? |
|
/retitle SDN-3732,SDN-3733,OCPBUGS-12747,OCPBUGS-16413,OCPBUGS-10650: [DownstreamMerge] 7-19-23 |
openshift-ci
bot
changed the title
|
@pperiyasamy: This pull request references SDN-3732 which is a valid jira issue. This pull request references SDN-3733 which is a valid jira issue. This pull request references Jira Issue OCPBUGS-12747, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jechen@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-16413, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jechen@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-10650, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test ci/prow/e2e-metal-ipi-ovn-ipv6 |
|
/test e2e-metal-ipi-ovn-ipv6 |
2 similar comments
|
/test e2e-metal-ipi-ovn-ipv6 |
|
/test e2e-metal-ipi-ovn-ipv6 |
|
CI failing at openshift/tools imagebackoff PodScheduled containerStatuses: - image: image-registry.openshift-image-registry.svc:5000/openshift/tools:latest imageID: "" lastState: {} name: agnhost-container ready: false restartCount: 0 started: false state: waiting: message: Back-off pulling image "image-registry.openshift-image-registry.svc:5000/openshift/tools:latest" reason: ImagePullBackOff hostIP: fd2e:6f44:5dd8:c956::17 |
|
nightly job is also failing due to the same reason |
|
/retest-required |
|
should we override this if we know exactly what's failing? we know |
Fine by me, @jcaamano are you ok overriding it ? |
|
/retest-required |
|
@pperiyasamy: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/hold cancel |
openshift-ci
bot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcaamano, npinaeva, pperiyasamy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@pperiyasamy: Jira Issue OCPBUGS-12747: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-12747 has been moved to the MODIFIED state. Jira Issue OCPBUGS-16413: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-16413 has been moved to the MODIFIED state. Jira Issue OCPBUGS-10650: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-10650 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @npinaeva