[wip] [release-4.13] node libovsdb #1764
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll want to store some more information here (like the server) so it won't just be for cleanup anymore. Signed-off-by: Dan Williams <dcbw@redhat.com> (cherry picked from commit 4a4046e)
This will let test code create the server test harness in BeforeEach() or other common code, but allow each testcase to update the server data before it runs tests. Previously if a testcase needed to use unique data in the server, it either had to throw away the common one and make a new one, or use libovsdbops functions to add the unique objects to the DB. Signed-off-by: Dan Williams <dcbw@redhat.com> (cherry picked from commit bc487cb)
Picks up named UUID handling changes and inactivity probes. Signed-off-by: Dan Williams <dcbw@redhat.com> (cherry picked from commit a234beb2bd887ea9bfe26af3ae4303e91b59888e)
Because of ovn-org/libovsdb#341 ("Refactor model updates") we need to rework how we pre-seed databases in testcases. Instead of directly creating table updates and committing them actually create libovsdb Operations and let a Transaction push them into the DB. This also means we get constraint validation (eg errors on duplicate or missing index keys) and forces us to make our unit test data actually work with a "real" database instead of taking shortcuts. A nice side-effect of converting the test data to Operations is that both updateData() (which writes directly to a DB) and CreateTestData() (which writes through a real Server) now have consistent behavior for test data handling. Next, because of ovn-org/libovsdb#359 ("Named UUID cleanup and enhancements") we can also simplify our handling of named UUIDS when pre-seeding databases in testcases. This is now handled for us by libovsdb's Transaction object so we can remove our named UUID replacement code for test input data. Signed-off-by: Dan Williams <dcbw@redhat.com> (cherry picked from commit 084955b4940d705a8f43364eba193702b0a68635)
Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com> (cherry picked from commit fc17f7e)
Signed-off-by: Dan Williams <dcbw@redhat.com> (cherry picked from commit 05855db4ea03f987b17997efb96c05b1ee51e291)
Used when we absolutely do not want to create the object (like a bridge) if it doesn't exist, because that should be a hard error, but just want to update it. Mostly to make sure testcases do the right thing, but we never actually want to create 'br-int' either, so it works for both testcases and real code. Signed-off-by: Dan Williams <dcbw@redhat.com> (cherry picked from commit 069157a053aca4ca77d999ffac4dd3ed670c1a7b)
Complement to Lookup() for chained operations. Signed-off-by: Dan Williams <dcbw@redhat.com> (cherry picked from commit 8a9c40a9a25ce375249e3ec4a4758d2a52e16112)
Signed-off-by: Dan Williams <dcbw@redhat.com> (cherry picked from commit 2e555e4800417c3f48bf0eb2ee789a7ccae61f73)
Signed-off-by: Dan Williams <dcbw@redhat.com> (cherry picked from commit 10b939196f82cb1782adefa05b7a8a2a1178c27d)
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dcbw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@dcbw: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What this PR does and why is it needed
- Special notes for reviewers
- How to verify it
- Description for the changelog