Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.13] OCPBUGS-17123: Remove stale egressip status entry #1793

Merged
merged 2 commits into from Sep 8, 2023
Merged

[release-4.13] OCPBUGS-17123: Remove stale egressip status entry #1793

merged 2 commits into from Sep 8, 2023

Conversation

pperiyasamy
Copy link
Member

Manual cherry-pick of 152ae1e 8dd5d2e c08382b and 712978d.
Conflicts due to complete redesign of egress ip module.
Needed to squash first 3 commits manually and did manual commit for the last one.

@pperiyasamy
Remove stale egressip status entry
22908f6 
This commit ensures egress ip status is in sync with cloud private ip config
on a restarted ovnk master because stale entry is noticed in the egress ip
status though cloud private ip config entry is not present for the given
egress ip.

Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
@pperiyasamy
Remove node check for syncing cloud private ip config
e190331 
This would remove node name comparison between cloud private ip config
and egress ip status as this is not valid in the case of egress ip
failover to another node during upgrade or reboot scenario.

Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 1, 2023
@openshift-ci-robot
Copy link
Contributor

@pperiyasamy: This pull request references Jira Issue OCPBUGS-17123, which is invalid:

  • expected dependent Jira Issue OCPBUGS-12747 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Manual cherry-pick of 152ae1e 8dd5d2e c08382b and 712978d.
Conflicts due to complete redesign of egress ip module.
Needed to squash first 3 commits manually and did manual commit for the last one.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from dcbw and trozet August 1, 2023 09:09
@pperiyasamy
Copy link
Member Author

/assign @jcaamano @flavio-fernandes @tssurya

@pperiyasamy
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Sep 1, 2023
@openshift-ci-robot
Copy link
Contributor

@pperiyasamy: This pull request references Jira Issue OCPBUGS-17123, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-12747 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-12747 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jechen@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 1, 2023
@pperiyasamy
Copy link
Member Author

/retest-required

@flavio-fernandes
Copy link
Contributor

/lgtm

TY Peri!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2023
@jechen0648
Copy link

/ocpbugs cc-qa

@jechen0648
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 1, 2023
@pperiyasamy
Copy link
Member Author

/retest-required

@jechen0648
Copy link

/retest

@jechen0648
Copy link

/test e2e-openstack-ovn

1 similar comment
@jechen0648
Copy link

/test e2e-openstack-ovn

@jcaamano
Copy link
Contributor

jcaamano commented Sep 7, 2023

/approve

@jcaamano
Copy link
Contributor

jcaamano commented Sep 7, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavio-fernandes, jcaamano, pperiyasamy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2023
@jechen0648
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 7, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 75d07f2 and 2 for PR HEAD e190331 in total

@jechen0648
Copy link

/test e2e-openstack-ovn

@jechen0648
Copy link

/test e2e-aws-ovn-shared-to-local-gateway-mode-migration

@jechen0648
Copy link

/test e2e-aws-ovn-local-to-shared-gateway-mode-migration

@jechen0648
Copy link

/test e2e-aws-ovn-shared-to-local-gateway-mode-migration

@jechen0648
Copy link

/test e2e-openstack-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 8, 2023

@pperiyasamy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-ovn e190331 link false /test e2e-openstack-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 16df936 into openshift:release-4.13 Sep 8, 2023
25 of 26 checks passed
@openshift-ci-robot
Copy link
Contributor

@pperiyasamy: Jira Issue OCPBUGS-17123: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-17123 has been moved to the MODIFIED state.

In response to this:

Manual cherry-pick of 152ae1e 8dd5d2e c08382b and 712978d.
Conflicts due to complete redesign of egress ip module.
Needed to squash first 3 commits manually and did manual commit for the last one.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pperiyasamy pperiyasamy mentioned this pull request Sep 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcbw dcbw Awaiting requested review from dcbw

@trozet trozet Awaiting requested review from trozet

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@flavio-fernandes flavio-fernandes

@tssurya tssurya

@jcaamano jcaamano

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@qiowang721 qiowang721

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet