[DownstreamMerge] 8-16-23 #1820
Conversation
The test is expecting on DB data before actually updating what it is supposed to expect on and expecting again after. Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
On syncPods there is an hybryd overlay route sync to clear out an outdated route. The logic is not matching on IP family so it ends up duplicating routes in dual stack configurations. Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
Fix duplicate routes after HO route sync
Fix BANP unit test flake
In-order to easily allow multiple consumers Signed-off-by: Martin Kennelly <mkennell@redhat.com>
Refactor route manager to reflect it is now its own pkg and should be renamed. Netlink library represents a dst with CIDR '0.0.0.0/0', aka 'blackhole' route as dst = nil, therefore we must work around this. This should be fixed with PR: vishvananda/netlink#852 Signed-off-by: Martin Kennelly <mkennell@redhat.com>
Signed-off-by: Martin Kennelly <mkennell@redhat.com>
…s item Signed-off-by: Martin Kennelly <mkennell@redhat.com>
Add components to allow consumers to set addrs on links, maintain state on links, and offer host addresses scan as a service excluding any managed addresses added. Signed-off-by: Martin Kennelly <mkennell@redhat.com>
Rule manager offers consumers a mechanism to add a rule and ensure its applied post adding. Also, adds a mechanism to own a priority which allows us to remove unexpected rules. Signed-off-by: Martin Kennelly <mkennell@redhat.com>
Offer to ensure rules persist even post application and also offer to "Own" a chain which will allow the consumer to clean or remove any stale entries. Signed-off-by: Martin Kennelly <mkennell@redhat.com>
- Networks are sourced from host-addresses annotation - Assignment is first attempted in the ovn managed primary network and if that fails, CM will attempt to assign to non-OVN managed networks. Signed-off-by: Martin Kennelly <mkennell@redhat.com>
Signed-off-by: Martin Kennelly <mkennell@redhat.com>
Signed-off-by: Martin Kennelly <mkennell@redhat.com>
Signed-off-by: Martin Kennelly <mkennell@redhat.com>
Signed-off-by: Martin Kennelly <mkennell@redhat.com>
Signed-off-by: Patryk Diak <pdiak@redhat.com>
Signed-off-by: Martin Kennelly <mkennell@redhat.com>
This controller will only react to EgressIPs that are hosted by an interface that is not managed by OVN-Kubernetes. The controller will ensure the correct state is applied to ensure egress IP support for non-OVN managed interfaces. Signed-off-by: Martin Kennelly <mkennell@redhat.com>
Signed-off-by: Martin Kennelly <mkennell@redhat.com>
Signed-off-by: Martin Kennelly <mkennell@redhat.com>
Signed-off-by: Martin Kennelly <mkennell@redhat.com>
Previous to this change, funcs were spawning goroutines which can escape netns Signed-off-by: Martin Kennelly <mkennell@redhat.com>
Signed-off-by: Martin Kennelly <mkennell@redhat.com>
Signed-off-by: Martin Kennelly <mkennell@redhat.com>
Signed-off-by: Martin Kennelly <mkennell@redhat.com>
Signed-off-by: Martin Kennelly <mkennell@redhat.com>
Signed-off-by: Martin Kennelly <mkennell@redhat.com>
The reason we are doing this is we do not support cloud env, and therefore we will waste limited resources on a non-supported platform. Signed-off-by: Martin Kennelly <mkennell@redhat.com>
Unknown why this is occuring. Works fine locally but on GH VM when running unit tests we get a permission denied when trying to create a new net ns. Signed-off-by: Martin Kennelly <mkennell@redhat.com>
|
/test e2e-aws-ovn-serial |
|
e2e-aws-ovn-hypershift failed /test e2e-aws-ovn-hypershift |
|
/test 4.14-upgrade-from-stable-4.13-local-gateway-e2e-aws-ovn-upgrade |
|
e2e-aws-ovn-hypershift failed to create hosted cluster multiple times, looks like it is related to the egressip change: |
|
/test e2e-metal-ipi-ovn-dualstack |
|
/test e2e-metal-ipi-ovn-ipv6 |
|
/test e2e-aws-ovn-hypershift |
maybe this is just a transient failure. |
|
known WMCO issue: https://redhat-internal.slack.com/archives/CM4ERHBJS/p1692035137053939 /override ci/prow/e2e-vsphere-ovn-windows |
|
@jcaamano: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow//e2e-vsphere-windows |
|
@jcaamano: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/e2e-aws-ovn-windows |
|
/override ci/prow/e2e-vsphere-windows |
|
@jcaamano: Overrode contexts on behalf of jcaamano: ci/prow/e2e-aws-ovn-windows In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jcaamano: Overrode contexts on behalf of jcaamano: ci/prow/e2e-vsphere-windows In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
The job seems to be failing because of an unrelated issue: /override ci/prow/e2e-metal-ipi-ovn-ipv6 |
|
@jcaamano: Overrode contexts on behalf of jcaamano: ci/prow/e2e-metal-ipi-ovn-ipv6 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcaamano, trozet, zshi-redhat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This is failing on a final step e2e-metal-ipi-ovn-dualstack-ofcir-release after the tests have already passed and even after gather extra has been collected so no chances of actually troubleshooting anything there. /override ci/prow/e2e-metal-ipi-ovn-dualstack |
|
@jcaamano: Overrode contexts on behalf of jcaamano: ci/prow/e2e-metal-ipi-ovn-dualstack In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-merge-robot
merged commit 973b7d0
into
openshift:master
|
@trozet: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Includes hybrid overlay fix and egress IP.
@martinkennelly @jcaamano FYI