Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.12] OCPBUGS-18681: Check libovsdbclient.ErrNotFound on wrapped errors #1862

Merged

Conversation

flavio-fernandes
Copy link
Contributor

Instead of looking explicitly for libovsdbclient.ErrNotFound, checking logic should account for cases when error has been wrapped.

In particular, this change addresses the logic in: func DeleteNATsOps()
https://github.com/ovn-org/ovn-kubernetes/blob/247483c8d1167072e04cf63e1c6e45264a25310e/go-controller/pkg/libovsdb/ops/router.go#L1078

when the error began to be wrapped as follows:
ovn-org/ovn-kubernetes@25d892c#r1317615944

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 7, 2023
@openshift-ci-robot
Copy link
Contributor

@flavio-fernandes: This pull request references Jira Issue OCPBUGS-18681, which is invalid:

  • expected dependent Jira Issue OCPBUGS-18672 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instead of looking explicitly for libovsdbclient.ErrNotFound, checking logic should account for cases when error has been wrapped.

In particular, this change addresses the logic in: func DeleteNATsOps()
https://github.com/ovn-org/ovn-kubernetes/blob/247483c8d1167072e04cf63e1c6e45264a25310e/go-controller/pkg/libovsdb/ops/router.go#L1078

when the error began to be wrapped as follows:
ovn-org/ovn-kubernetes@25d892c#r1317615944

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@flavio-fernandes
Copy link
Contributor Author

/retest-required

3 similar comments
@flavio-fernandes
Copy link
Contributor Author

/retest-required

@flavio-fernandes
Copy link
Contributor Author

/retest-required

@flavio-fernandes
Copy link
Contributor Author

/retest-required

@jechen0648
Copy link

/ocpbugs cc-qa

@jechen0648
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 22, 2023
@jechen0648
Copy link

/retest

@jechen0648
Copy link

/test e2e-aws-ovn-local-to-shared-gateway-mode-migration

@jechen0648
Copy link

/test e2e-aws-ovn-shared-to-local-gateway-mode-migration

@jechen0648
Copy link

/test e2e-openstack-ovn

@flavio-fernandes
Copy link
Contributor Author

/retest-required

1 similar comment
@flavio-fernandes
Copy link
Contributor Author

/retest-required

@flavio-fernandes
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 25, 2023
@openshift-ci-robot
Copy link
Contributor

@flavio-fernandes: This pull request references Jira Issue OCPBUGS-18681, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-18672 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-18672 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@flavio-fernandes
Copy link
Contributor Author

/retest-required

4 similar comments
@flavio-fernandes
Copy link
Contributor Author

/retest-required

@flavio-fernandes
Copy link
Contributor Author

/retest-required

@flavio-fernandes
Copy link
Contributor Author

/retest-required

@flavio-fernandes
Copy link
Contributor Author

/retest-required

@flavio-fernandes
Copy link
Contributor Author

/test e2e-gcp-ovn

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD b982540 and 2 for PR HEAD 66cf9f9 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 97c5073 and 1 for PR HEAD 66cf9f9 in total

@flavio-fernandes
Copy link
Contributor Author

/retest-required

@flavio-fernandes
Copy link
Contributor Author

/override ci/prow/e2e-aws-ovn-local-to-shared-gateway-mode-migration /override ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration

hi @jcaamano can you please do the override again? We need it until https://github.com/openshift/cluster-network-operator/pull/205 is merged.

@jcaamano
Copy link
Contributor

/override ci/prow/e2e-aws-ovn-local-to-shared-gateway-mode-migration /override ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2023

@jcaamano: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • /override

Only the following failed contexts/checkruns were expected:

  • ci/prow/4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade
  • ci/prow/4.12-upgrade-from-stable-4.11-images
  • ci/prow/4.12-upgrade-from-stable-4.11-local-gateway-e2e-aws-ovn-upgrade
  • ci/prow/4.12-upgrade-from-stable-4.11-local-gateway-images
  • ci/prow/e2e-aws-ovn
  • ci/prow/e2e-aws-ovn-hypershift
  • ci/prow/e2e-aws-ovn-local-gateway
  • ci/prow/e2e-aws-ovn-local-to-shared-gateway-mode-migration
  • ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration
  • ci/prow/e2e-aws-ovn-upgrade
  • ci/prow/e2e-aws-ovn-upgrade-local-gateway
  • ci/prow/e2e-aws-ovn-windows
  • ci/prow/e2e-azure-ovn
  • ci/prow/e2e-gcp-ovn
  • ci/prow/e2e-metal-ipi-ovn-dualstack
  • ci/prow/e2e-metal-ipi-ovn-ipv6
  • ci/prow/e2e-openstack-ovn
  • ci/prow/e2e-ovn-hybrid-step-registry
  • ci/prow/e2e-vsphere-ovn
  • ci/prow/e2e-vsphere-windows
  • ci/prow/gofmt
  • ci/prow/images
  • ci/prow/lint
  • ci/prow/okd-images
  • ci/prow/unit
  • pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn
  • pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-hypershift
  • pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-local-gateway
  • pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-local-to-shared-gateway-mode-migration
  • pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-shared-to-local-gateway-mode-migration
  • pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-upgrade
  • pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-upgrade-local-gateway
  • pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-windows
  • pull-ci-openshift-ovn-kubernetes-master-e2e-azure-ovn
  • pull-ci-openshift-ovn-kubernetes-master-e2e-gcp-ovn
  • pull-ci-openshift-ovn-kubernetes-master-e2e-metal-ipi-ovn-dualstack
  • pull-ci-openshift-ovn-kubernetes-master-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-ovn-kubernetes-master-e2e-openstack-ovn
  • pull-ci-openshift-ovn-kubernetes-master-e2e-ovn-hybrid-step-registry
  • pull-ci-openshift-ovn-kubernetes-master-e2e-vsphere-ovn
  • pull-ci-openshift-ovn-kubernetes-master-e2e-vsphere-windows
  • pull-ci-openshift-ovn-kubernetes-master-gofmt
  • pull-ci-openshift-ovn-kubernetes-master-images
  • pull-ci-openshift-ovn-kubernetes-master-lint
  • pull-ci-openshift-ovn-kubernetes-master-okd-images
  • pull-ci-openshift-ovn-kubernetes-master-unit
  • pull-ci-openshift-ovn-kubernetes-release-4.12-4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade
  • pull-ci-openshift-ovn-kubernetes-release-4.12-4.12-upgrade-from-stable-4.11-images
  • pull-ci-openshift-ovn-kubernetes-release-4.12-4.12-upgrade-from-stable-4.11-local-gateway-e2e-aws-ovn-upgrade
  • pull-ci-openshift-ovn-kubernetes-release-4.12-4.12-upgrade-from-stable-4.11-local-gateway-images
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override ci/prow/e2e-aws-ovn-local-to-shared-gateway-mode-migration /override ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcaamano
Copy link
Contributor

/override ci/prow/e2e-aws-ovn-local-to-shared-gateway-mode-migration
/override ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2023

@jcaamano: Overrode contexts on behalf of jcaamano: ci/prow/e2e-aws-ovn-local-to-shared-gateway-mode-migration, ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration

In response to this:

/override ci/prow/e2e-aws-ovn-local-to-shared-gateway-mode-migration
/override ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD daeb70a and 0 for PR HEAD 66cf9f9 in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 66cf9f9 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2023
@flavio-fernandes
Copy link
Contributor Author

/remove-hold

@flavio-fernandes
Copy link
Contributor Author

/retest-required

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2023
@flavio-fernandes
Copy link
Contributor Author

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD daeb70a and 2 for PR HEAD 66cf9f9 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2023

@flavio-fernandes: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-ovn 66cf9f9 link false /test e2e-openstack-ovn
ci/prow/e2e-vsphere-ovn 66cf9f9 link false /test e2e-vsphere-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@flavio-fernandes
Copy link
Contributor Author

/retest-required

@openshift-ci openshift-ci bot merged commit dd3c7ed into openshift:release-4.12 Oct 18, 2023
24 of 26 checks passed
@openshift-ci-robot
Copy link
Contributor

@flavio-fernandes: Jira Issue OCPBUGS-18681: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-18681 has been moved to the MODIFIED state.

In response to this:

Instead of looking explicitly for libovsdbclient.ErrNotFound, checking logic should account for cases when error has been wrapped.

In particular, this change addresses the logic in: func DeleteNATsOps()
https://github.com/ovn-org/ovn-kubernetes/blob/247483c8d1167072e04cf63e1c6e45264a25310e/go-controller/pkg/libovsdb/ops/router.go#L1078

when the error began to be wrapped as follows:
ovn-org/ovn-kubernetes@25d892c#r1317615944

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@flavio-fernandes flavio-fernandes deleted the err_wrap.ds.4.12 branch October 18, 2023 23:55
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-ovn-kubernetes-base-container-v4.12.0-202311220908.p0.gdd3c7ed.assembly.stream for distgit ovn-kubernetes-base.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet