New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.12] OCPBUGS-18681: Check libovsdbclient.ErrNotFound on wrapped errors #1862
[release-4.12] OCPBUGS-18681: Check libovsdbclient.ErrNotFound on wrapped errors #1862
Conversation
@flavio-fernandes: This pull request references Jira Issue OCPBUGS-18681, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
924faa7
to
b78f535
Compare
/retest-required |
3 similar comments
/retest-required |
/retest-required |
/retest-required |
/ocpbugs cc-qa |
/label qe-approved |
/retest |
/test e2e-aws-ovn-local-to-shared-gateway-mode-migration |
/test e2e-aws-ovn-shared-to-local-gateway-mode-migration |
/test e2e-openstack-ovn |
/retest-required |
1 similar comment
/retest-required |
/jira refresh |
@flavio-fernandes: This pull request references Jira Issue OCPBUGS-18681, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest-required |
4 similar comments
/retest-required |
/retest-required |
/retest-required |
/retest-required |
/test e2e-gcp-ovn |
/retest-required |
hi @jcaamano can you please do the override again? We need it until https://github.com/openshift/cluster-network-operator/pull/205 is merged. |
/override ci/prow/e2e-aws-ovn-local-to-shared-gateway-mode-migration /override ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration |
@jcaamano: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override ci/prow/e2e-aws-ovn-local-to-shared-gateway-mode-migration |
@jcaamano: Overrode contexts on behalf of jcaamano: ci/prow/e2e-aws-ovn-local-to-shared-gateway-mode-migration, ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold Revision 66cf9f9 was retested 3 times: holding |
/remove-hold |
/retest-required |
/retest-required |
@flavio-fernandes: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest-required |
dd3c7ed
into
openshift:release-4.12
@flavio-fernandes: Jira Issue OCPBUGS-18681: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-18681 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-ovn-kubernetes-base-container-v4.12.0-202311220908.p0.gdd3c7ed.assembly.stream for distgit ovn-kubernetes-base. |
Instead of looking explicitly for libovsdbclient.ErrNotFound, checking logic should account for cases when error has been wrapped.
In particular, this change addresses the logic in: func DeleteNATsOps()
https://github.com/ovn-org/ovn-kubernetes/blob/247483c8d1167072e04cf63e1c6e45264a25310e/go-controller/pkg/libovsdb/ops/router.go#L1078
when the error began to be wrapped as follows:
ovn-org/ovn-kubernetes@25d892c#r1317615944