New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-18402: Make ovnkube-trace to work for ovnkube-controller #1864
OCPBUGS-18402: Make ovnkube-trace to work for ovnkube-controller #1864
Conversation
The ovnkube-node container is merged into ovnkube-controller container in an interconnect environment, it created regression in ovnkube-trace command. Hence this commit provides relevant fixes for the command so that it works seamlessly on this environment. Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com> (cherry picked from commit e766245)
@pperiyasamy: This pull request references Jira Issue OCPBUGS-18402, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcaamano, kyrtapz, pperiyasamy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/jira refresh The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity. |
@openshift-bot: This pull request references Jira Issue OCPBUGS-18402, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@pperiyasamy: This pull request references Jira Issue OCPBUGS-18402, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest-required |
1 similar comment
/retest-required |
@pperiyasamy: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
wait these are not critical bugs right why are we cherry-picking them? the more we cherry-pick the more chance of conflicts, why don't we wait for d/s merge? |
closing it in favor of #1868. |
@pperiyasamy: This pull request references Jira Issue OCPBUGS-18402. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Clean cherry-pick of ovn-org/ovn-kubernetes#3889.
/assign @kyrtapz @trozet