[release-4.12] Serve NodePort services on secondary IP addresses #1865
Conversation
These will be used for per node NB configurations (e.g., load balancer templates). Signed-off-by: Dumitru Ceara <dceara@redhat.com> (cherry picked from commit 9ded3d8)
An upcoming commit will need to make some decisions based on the node IP address family. To avoid re-parsing nodeIPs, just store them as net.IP. Signed-off-by: Dumitru Ceara <dceara@redhat.com> (cherry picked from commit c258f60)
Asserting on `netexec` response to not containing errors does not allow using retries, as the test would fail during the first attempt. Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
When a node gets a new IP addresses, node loadbalancers should be updated to serve NodePort services on the new address. Update node_tracker.go to track both `host-addresses` and `l3-gateway-config` IP addresses, as they are used in different ways for building load balancers. Add End2End test to control-plane suite. Update load balancer unit tests to include a multi address node. Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
For NodePort Services with ExternalTrafficPolicy = Local, incoming connections shouldn't be DNATted to masqueradeIP. Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
Refs: ovn-org/ovn-kubernetes#3328 Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
The test about NodePort services that are reachable on every host IP address should reside in the Service suite. Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zeeke The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
@zeeke: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
/close |
|
@tssurya: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Backport of: