Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-19501: Add additonal certificate acceptance condition feature in ovnkube-ide… #1895

Merged
merged 1 commit into from Sep 22, 2023
Merged

OCPBUGS-19501: Add additonal certificate acceptance condition feature in ovnkube-ide… #1895

merged 1 commit into from Sep 22, 2023

Conversation

s1061123
Copy link
Contributor

@s1061123 s1061123 commented Sep 20, 2023 •
edited

No description provided.

@s1061123
Add additonal certificate acceptance condition feature in ovnkube-ide…
1855b42 
…ntity

This change introduces additional certificate acceptance condition so that
other components reuse ovnkube-identity.

Signed-off-by: Tomofumi Hayashi <tohayash@redhat.com>
@s1061123 s1061123 requested a review from dcbw as a code owner September 20, 2023 17:28
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 20, 2023
@openshift-ci-robot
Copy link
Contributor

@s1061123: This pull request references Jira Issue OCPBUGS-19501, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

…ntity

This change introduces additional certificate acceptance condition so that other components reuse ovnkube-identity.

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@s1061123: This pull request references Jira Issue OCPBUGS-19501, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dougbtv dougbtv mentioned this pull request Sep 20, 2023
Closed
@zshi-redhat
Copy link
Contributor

/retest-required

3 similar comments
@s1061123
Copy link
Contributor Author

/retest-required

@s1061123
Copy link
Contributor Author

/retest-required

@s1061123
Copy link
Contributor Author

/retest-required

@s1061123
Copy link
Contributor Author

/test e2e-aws-ovn

@jcaamano
Copy link
Contributor

/retest

@kyrtapz
Copy link
Contributor

kyrtapz commented Sep 21, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2023
@jcaamano
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaamano, kyrtapz, s1061123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD bed0a00 and 2 for PR HEAD 1855b42 in total

@kyrtapz
Copy link
Contributor

kyrtapz commented Sep 21, 2023

Most of the CI failures seem to be related to image registry issues:

Trying to pull image-registry.openshift-image-registry.svc:5000/ci-op-fpzz18dq/pipeline@sha256:ff5716ed9d36549cd92b49c05fd93e7bae0b1dc7c0b148a031c04fd7b19995a5...
error: error creating buildah builder: initializing source docker://image-registry.openshift-image-registry.svc:5000/ci-op-fpzz18dq/pipeline@sha256:ff5716ed9d36549cd92b49c05fd93e7bae0b1dc7c0b148a031c04fd7b19995a5: reading manifest sha256:ff5716ed9d36549cd92b49c05fd93e7bae0b1dc7c0b148a031c04fd7b19995a5 in image-registry.openshift-image-registry.svc:5000/ci-op-fpzz18dq/pipeline: received unexpected HTTP status: 500 Internal Server Error
...
...
* 2023-09-21T14:47:44Z 3x kubelet: Pulling image "image-registry.openshift-image-registry.svc:5000/ci-op-ldqxz36v/pipeline@sha256:ec16f510e8cd1cceeddc6888fcb37c6d6b7c6863fbc70bdbe660a8ccad4bab6a"
* 2023-09-21T14:47:45Z 3x kubelet: Failed to pull image "image-registry.openshift-image-registry.svc:5000/ci-op-ldqxz36v/pipeline@sha256:ec16f510e8cd1cceeddc6888fcb37c6d6b7c6863fbc70bdbe660a8ccad4bab6a": rpc error: code = Unknown desc = fetching target platform image selected from manifest list: reading manifest sha256:a1801b843b1bfaf77c501e7a6d3f709401a1e0c83863037fa3aab063a7fdb9dc in image-registry.openshift-image-registry.svc:5000/ci-op-ldqxz36v/pipeline: manifest unknown: manifest unknown
* 2023-09-21T14:47:45Z 3x kubelet: Error: ErrImagePull
* 2023-09-21T14:46:39Z 1x kubelet: Container image "gcr.io/k8s-prow/sidecar:v20230920-7b72c6f3a0" already present on machine
* 2023-09-21T14:46:40Z 1x kubelet: Created container sidecar
* 2023-09-21T14:46:40Z 1x kubelet: Started container sidecar
* 2023-09-21T15:11:42Z 106x kubelet: Back-off pulling image "image-registry.openshift-image-registry.svc:5000/ci-op-ldqxz36v/pipeline@sha256:ec16f510e8cd1cceeddc6888fcb37c6d6b7c6863fbc70bdbe660a8ccad4bab6a"
* 2023-09-21T14:47:06Z 3x kubelet: Error: ImagePullBackOff 
�[36mINFO�[0m[2023-09-21T15:16:38Z] Step e2e-aws-ovn-windows-ipi-conf failed after 30m1s. 
�[36mINFO�[0m[2023-09-21T15:16:38Z] Step phase pre failed after 30m1s.

/retest-required

@dougbtv
Copy link
Member

dougbtv commented Sep 21, 2023

/retest-required

@dougbtv
Copy link
Member

dougbtv commented Sep 21, 2023

/test 4.14-upgrade-from-stable-4.13-local-gateway-e2e-aws-ovn-upgrade

@zshi-redhat
Copy link
Contributor

/test e2e-aws-ovn-serial

@zshi-redhat
Copy link
Contributor

/test 4.14-upgrade-from-stable-4.13-local-gateway-e2e-aws-ovn-upgrade

@dougbtv
Copy link
Member

dougbtv commented Sep 22, 2023

/retest-required

1 similar comment
@knobunc
Copy link
Contributor

knobunc commented Sep 22, 2023

/retest-required

@zshi-redhat
Copy link
Contributor

/retest-required

2 similar comments
@zshi-redhat
Copy link
Contributor

/retest-required

@s1061123
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2023 •
edited

@s1061123: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-ovn 1855b42 link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-kubevirt 1855b42 link false /test e2e-aws-ovn-kubevirt
ci/prow/e2e-vsphere-ovn 1855b42 link false /test e2e-vsphere-ovn
ci/prow/e2e-ovn-hybrid-step-registry 1855b42 link false /test e2e-ovn-hybrid-step-registry

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@s1061123
Copy link
Contributor Author

/retest-required

@jcaamano
Copy link
Contributor

/override ci/prow/e2e-vsphere-windows

This job passed before on the same set of changes. The last attempt failed due to infra related issue, not related to these changes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2023

@jcaamano: Overrode contexts on behalf of jcaamano: ci/prow/e2e-vsphere-windows

In response to this:

/override ci/prow/e2e-vsphere-windows

This job passed before on the same set of changes. The last attempt failed due to infra related issue, not related to these changes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@s1061123
Copy link
Contributor Author

/retest-required

@jcaamano
Copy link
Contributor

/override ci/prow/e2e-metal-ipi-ovn-dualstack
/override ci/prow/e2e-metal-ipi-ovn-ipv6

Overriding jobs that passed before on the same changeset.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2023

@jcaamano: Overrode contexts on behalf of jcaamano: ci/prow/e2e-metal-ipi-ovn-dualstack, ci/prow/e2e-metal-ipi-ovn-ipv6

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-dualstack
/override ci/prow/e2e-metal-ipi-ovn-ipv6

Overriding jobs that passed before on the same changeset.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit ec6072a into openshift:master Sep 22, 2023
25 of 29 checks passed
@openshift-ci-robot
Copy link
Contributor

@s1061123: Jira Issue OCPBUGS-19501: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-19501 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@s1061123 s1061123 deleted the ovn-cert-ocp branch September 22, 2023 10:58
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2023-09-27-073353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcbw dcbw Awaiting requested review from dcbw

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

@jcaamano jcaamano Awaiting requested review from jcaamano

@trozet trozet Awaiting requested review from trozet

Assignees

@kyrtapz kyrtapz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@s1061123 @openshift-ci-robot @zshi-redhat @jcaamano @kyrtapz @dougbtv @knobunc @openshift-merge-robot