Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.11] OCPBUGS-19650: Delete IGMP Groups when deleting stale chassis #1901

Merged
merged 3 commits into from Sep 25, 2023
Merged

[release-4.11] OCPBUGS-19650: Delete IGMP Groups when deleting stale chassis #1901

merged 3 commits into from Sep 25, 2023

Conversation

npinaeva
Copy link
Member

backport of #1516

npinaeva and others added 3 commits September 22, 2023 15:04
@npinaeva
Delete IGMP Groups when deleting stale chassis.
1fd5e47 
IGMPGroup has a weak link to chassis, deleting multiple chassis may
result in IGMP_Groups with identical values on columns "address",
"datapath", and "chassis", when "chassis" goes empty

Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
(cherry picked from commit 14ab317)
(cherry picked from commit 5989055)
@npinaeva
vendor: bump libovsdb to a6a1739938309190e605e21bd756035313c39741
f8a2777 
Pulls in the following commits, for which we really just care
about the fixes handling column indexes with nil values.
Previous commit used was 8f21d188c3a50d0ce378bd66ec68215967aaad77

Commits:

  3dfe3b2 Fixes handling column indexes with nil values
  a4f2602 Expose getter functions for fields with modelgen
  48820f4 client: Support conditional monitoring.
  b49e8a2 Move NewMonitorRequest from mapper to client.
  eec7889 transaction: inserted rows not accounted for later ops
  f93641e database: index uniqueness is a deferred constraint
  324d6fd cache: don't update indexes on error
  3425de9 cache: fix index exists checks
  0e3936d transaction: equal number of operations and results
  e18d25f transaction: Remove database name from methods
  74f2131 move database & transaction to its own package

Recipe for doing this bump:

  cd ./go-controller
  go get -u github.com/ovn-org/libovsdb@main
  go mod vendor && go mod tidy && echo ok
  git add go.mod go.sum vendor

Signed-off-by: Flavio Fernandes <flaviof@redhat.com>
(cherry picked from commit b5b61bc)
Conflicts: re-applied command provided by Flavio
Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
(cherry picked from commit 7278edc)
Conflicts: re-applied command provided by Flavio
Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
@flavio-fernandes @npinaeva
libovsdb bump: use database package
ac1d7d0 
server.Database ==> database.Database

Signed-off-by: Flavio Fernandes <flaviof@redhat.com>
(cherry picked from commit 2f01717)
(cherry picked from commit 7f0683d)
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 22, 2023
@openshift-ci-robot
Copy link
Contributor

@npinaeva: This pull request references Jira Issue OCPBUGS-19650, which is invalid:

  • expected the bug to target the "4.11.z" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

backport of #1516

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@npinaeva
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 22, 2023
@openshift-ci-robot
Copy link
Contributor

@npinaeva: This pull request references Jira Issue OCPBUGS-19650, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.11.z) matches configured target version for branch (4.11.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-7230 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-7230 targets the "4.12.z" version, which is one of the valid target versions: 4.12.0, 4.12.z
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@npinaeva
Copy link
Member Author

@flavio-fernandes can you please lgtm the libovsdb bump?

flavio-fernandes
flavio-fernandes reviewed Sep 22, 2023
View reviewed changes
Copy link
Contributor

@flavio-fernandes flavio-fernandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2023
@flavio-fernandes
Copy link
Contributor

/test unit

@flavio-fernandes
Copy link
Contributor

/retest-required

@dcbw
Copy link
Contributor

dcbw commented Sep 22, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, flavio-fernandes, npinaeva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2023

@npinaeva: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-hypershift ac1d7d0 link false /test e2e-hypershift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dcbw dcbw added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 25, 2023
@asood-rh
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 25, 2023
@openshift-merge-robot openshift-merge-robot merged commit 0dbe16b into openshift:release-4.11 Sep 25, 2023
26 of 27 checks passed
@openshift-ci-robot
Copy link
Contributor

@npinaeva: Jira Issue OCPBUGS-19650: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-19650 has been moved to the MODIFIED state.

In response to this:

backport of #1516

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@npinaeva npinaeva deleted the ocpbugs-19650 branch September 25, 2023 13:31
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.11.0-0.nightly-2023-09-27-073608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavio-fernandes flavio-fernandes flavio-fernandes left review comments

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

@trozet trozet Awaiting requested review from trozet

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@flavio-fernandes flavio-fernandes

@weliang1 weliang1

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@yingwang-0320 yingwang-0320

@qiowang721 qiowang721

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet