Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-18652: Do not return error if pod IP cannot be retrieved for deletePeerPod and perf improvements #1903

Merged
merged 3 commits into from Sep 26, 2023
Merged

OCPBUGS-18652: Do not return error if pod IP cannot be retrieved for deletePeerPod and perf improvements #1903

merged 3 commits into from Sep 26, 2023

Conversation

martinkennelly
Copy link
Contributor

Do not return error if pod IP cannot be retrieved for podPeerPod and perf improvements for retrieving the pod IPs.

@martinkennelly
Speed up getting pod ips from pod with default network
cb77d14 
It was seen in perf/scale runs that unmarshaling pod annotation on a lot
of remote pod deletes (for address set removal) was taking a lot of CPU.
Change the order of getting pod IP to use kapi pod.IPs rather than
annotation for default network.

Signed-off-by: Tim Rozet <trozet@redhat.com>
(cherry picked from commit 6b2088b)
@martinkennelly
More perf optimizations with searching for Pod IPs
5f784f7 
Changes-Include:
 - Minor improvement when ensuring remote zone pod to not always get the
   pod IPs
 - Major improvement to searching for colliding IPs where we can filter
   pods only specific to the node where the original pod resided. This
   search is applicable when the pods are not kubevirt migratable and
   the topology type is Layer 3.

Signed-off-by: Tim Rozet <trozet@redhat.com>
(cherry picked from commit c9fa5bb)
@martinkennelly
Handle pod IPs correctly for address set selector
7bd29ae 
Changes-Include:
 - On pod add/update the IP not might be available yet, since another
   node might be allocating its IP. Suppress the error.
 - Warning was printing a wrapped error object
 - On completed pods check, if the pod had no IP, it would cause an
   error and be retried. If the pod is completed and has no IP, we
   should not retry or log error.
---
Note on BP:
Only the third item in the list above is valid for this cherry-pick
and even then this code path is very different on 4.12 and does not
match the original commit.
The goal of the said commit is clear - during the deletion path
in netpol related funcs, ensure that we do not return an error
if we fail to find selected pod IPs that will never be found.

Signed-off-by: Tim Rozet <trozet@redhat.com>
(cherry picked from commit d7d9a56)
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 25, 2023
@openshift-ci-robot
Copy link
Contributor

@martinkennelly: This pull request references Jira Issue OCPBUGS-18652, which is invalid:

  • expected dependent Jira Issue OCPBUGS-19449 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Do not return error if pod IP cannot be retrieved for podPeerPod and perf improvements for retrieving the pod IPs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@npinaeva
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2023
@martinkennelly martinkennelly changed the title OCPBUGS-18652: Do not return error if pod IP cannot be retrieved for podSelectorPodNeedsDelete and perf improvements OCPBUGS-18652: Do not return error if pod IP cannot be retrieved for deletePeerPod and perf improvements Sep 25, 2023
@martinkennelly
Copy link
Contributor Author

GW mode migration jobs will never pass on 4.12. They always need override. @jluhrsen is working on fixing it.

@martinkennelly
Copy link
Contributor Author

/test e2e-gcp-ovn

unrelated failure

@martinkennelly
Copy link
Contributor Author

/test e2e-vsphere-windows
Unrelated failure

trozet
trozet approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@trozet trozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: martinkennelly, npinaeva, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2023
@martinkennelly
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Sep 26, 2023
@openshift-ci-robot
Copy link
Contributor

@martinkennelly: This pull request references Jira Issue OCPBUGS-18652, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-19449 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-19449 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jechen@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 26, 2023
@huiran0826
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 26, 2023
@martinkennelly
Copy link
Contributor Author

/test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade

@martinkennelly
Copy link
Contributor Author

/test e2e-metal-ipi-ovn-dualstack

Unrelated failures

@martinkennelly
Copy link
Contributor Author

/test e2e-openstack-ovn

Known failure:

The Openstack platform should re-use an existing UDP Amphora LoadBalancer when new svc is created on Openshift with the proper annotation

@martinkennelly
Copy link
Contributor Author

Gateway mode migration jobs are perma-failing and will be fixed by: https://issues.redhat.com/browse/OCPBUGS-17391

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c40f9a2 and 2 for PR HEAD 7bd29ae in total

@dcbw
Copy link
Contributor

dcbw commented Sep 26, 2023

/override ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration
/override ci/prow/e2e-aws-ovn-local-to-shared-gateway-mode-migration

Unrelated and should be fixed by https://issues.redhat.com/browse/OCPBUGS-17391

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 26, 2023

@dcbw: Overrode contexts on behalf of dcbw: ci/prow/e2e-aws-ovn-local-to-shared-gateway-mode-migration, ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration

In response to this:

/override ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration
/override ci/prow/e2e-aws-ovn-local-to-shared-gateway-mode-migration

Unrelated and should be fixed by https://issues.redhat.com/browse/OCPBUGS-17391

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@martinkennelly
Copy link
Contributor Author

e2e-openstack-ovn failed with unrelated flake:

event happened 37 times, something is wrong: ns/openshift-authentication-operator deployment/authentication-operator - reason/OpenShiftAPICheckFailed "user.openshift.io.v1" failed with an attempt failed with statusCode = 503, err = the server is currently unable to handle the request}

@martinkennelly
Copy link
Contributor Author

martinkennelly commented Sep 26, 2023 •
edited

CI retested everything again sigh - no idea why since every required job passed... It didnt seem to respect the overridden GW mode jobs.

@martinkennelly: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-local-to-shared-gateway-mode-migration 7bd29ae link true /test e2e-aws-ovn-local-to-shared-gateway-mode-migration
ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration 7bd29ae link true /test e2e-aws-ovn-shared-to-local-gateway-mode-migration
ci/prow/e2e-openstack-ovn 7bd29ae link false /test e2e-openstack-ovn

@martinkennelly
Copy link
Contributor Author

/tide refresh

@jechen0648
Copy link

/ocpbugs cc-qa

@jechen0648
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 26, 2023
@martinkennelly
Copy link
Contributor Author

/test e2e-aws-ovn
Unrelated flake for CSI volumes

@martinkennelly
Copy link
Contributor Author

/test e2e-aws-ovn-upgrade-local-gateway
Flake - telemeter alert fired. No indication its related to this PR.

@martinkennelly
Copy link
Contributor Author

/test e2e-aws-ovn-upgrade

Telemeter alert fired again... No indication its related to this PR. Retesting to see if its flake. I downloaded MG and tried to find reason but failed to do so.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 26, 2023

@martinkennelly: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-ovn 7bd29ae link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-local-to-shared-gateway-mode-migration 7bd29ae link true /test e2e-aws-ovn-local-to-shared-gateway-mode-migration
ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration 7bd29ae link true /test e2e-aws-ovn-shared-to-local-gateway-mode-migration

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 4af0a99 into openshift:release-4.12 Sep 26, 2023
25 of 26 checks passed
@openshift-ci-robot
Copy link
Contributor

@martinkennelly: Jira Issue OCPBUGS-18652: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-18652 has been moved to the MODIFIED state.

In response to this:

Do not return error if pod IP cannot be retrieved for podPeerPod and perf improvements for retrieving the pod IPs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.12.0-0.nightly-2023-09-27-051001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trozet trozet trozet approved these changes

@jcaamano jcaamano Awaiting requested review from jcaamano

@tssurya tssurya Awaiting requested review from tssurya

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@npinaeva npinaeva

@weliang1 weliang1

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@yingwang-0320 yingwang-0320

@qiowang721 qiowang721

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet