-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Sync netpol ACL filter #1947
Conversation
multicast ACLs have similar ExternalIDs, but different priority. Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
@npinaeva: This pull request references Jira Issue OCPBUGS-21668, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: npinaeva The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@npinaeva: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@npinaeva: No Jira issue is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The intent was to fix network policy port groups being wrongly deleted because of interpreting multicast ACLs as netpol ACLs. Even though multicast ACL can actually give here either a real namespace name or "clusterRtrPortGroup", extra check https://github.com/openshift/ovn-kubernetes/blob/release-4.13/go-controller/pkg/ovn/policy.go#L352 won't let it delete network policy that actually exists. Also deleting a port group that doesn't exist won't return an error https://github.com/openshift/ovn-kubernetes/blob/master/go-controller/pkg/libovsdb/ops/portgroup.go#L263 |
Fix syncNetworkPolicy ACLs filter to not include multicast ACLs, since
multicast ACLs have similar ExternalIDs, but different priority.
Was introduced in 4.13 #1603 and not backported.
Fixed in 4.14 since ovn-org/ovn-kubernetes@2aab19e#diff-cc83e19af1c257d5a09b711d5977d8f8c20beb34b7b5d3eb37b2f2c53ded1bf7R293-R295