New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NHE-805,OCPBUGS-19050,OCPBUGS-22691,OCPBUGS-22767,SDN-4173: [DownstreamMerge] 11 November 2023 #1952
NHE-805,OCPBUGS-19050,OCPBUGS-22691,OCPBUGS-22767,SDN-4173: [DownstreamMerge] 11 November 2023 #1952
Conversation
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.53.0 to 1.56.3. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.53.0...v1.56.3) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
cluster. With the previous params we only allowed 1 retry in case tryAcquireOrRenew failed within 10 seconds, and no retry otherwise. When etcd is overloaded, lease requests may timeout in 10 seconds, and that will result in giving up the leadership without retry. For big clusters leadership change may be a problem, because initial sync of ovnk-master may take hours and during that time no new requests are handled, so we better be a bit more conservative on giving up the leadership Handle panics in runOvnKube to ensure proper shutdown. Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
…onfiguration Starting from CNI 1.0.0, the only accepted configuration format possible features a config list of plugins: https://github.com/containernetworking/cni/blob/main/SPEC.md#configuration-format Support plugin list, in addition to single plugin configuration. Signed-off-by: Or Shoval <oshoval@redhat.com>
delete all acls that were not synced since they should be stale. Add unit test for a specific multicast leftover acl that was a result of libovsdb migration. Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 20.10.24+incompatible to 24.0.7+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v20.10.24...v24.0.7) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…google.golang.org/grpc-1.56.3 Bump google.golang.org/grpc from 1.53.0 to 1.56.3 in /test/e2e
Update leaderelection config to allow retries
…github.com/docker/docker-24.0.7incompatible Bump github.com/docker/docker from 20.10.24+incompatible to 24.0.7+incompatible in /test/e2e
Signed-off-by: Leonardo Milleri <lmilleri@redhat.com>
Permit models to update and mutate columns within a single transaction operation. For example: opModels := []operationModel{ { Model: chassis, OnModelMutations: []interface{}{&chassis.OtherConfig}, <--- OnModelUpdates: []interface{}{&chassis.Encaps}, <--- ErrNotFound: false, BulkOp: false, }, } Signed-off-by: Flavio Fernandes <flaviof@redhat.com>
For each chassis, there should only be only 1 encap-ip. However the OVN database allows for multiple encap-ips per chassis. In order to recover from a situation where the database already has an existing encap-ip for a chassis and there is a different encap-ip being added to the chassis; we introduce this fix to use "OnModelUpdates" to override the chassis encaps instead of previously appending to it. Note: This can happen in the case of the DPU because the DPU can have the incorrect encap-ip stored in the SBDB because converting the cluster to DPU-aware may not be a Day0/1 operation but rather a Day2 operation. Co-authored-by: Flavio Fernandes <flaviof@redhat.com> Signed-off-by: William Zhao <wizhao@redhat.com>
check Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
EgressFIrewall e2e fix
Update ACL syncer: make default deny acls filter more strict,
namespace address set. Existing port groups don't need any change, since port group name always was a namespace name. Set ErrNotFound to false for delete acls and ports from port group ops. Namespace handler will create, update and delete namespace port group similar to the namespace address set. Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
cluster port group + address set match to reduce the number of OVS flows. Previously, all EF ACLs were applied to the clusterPortGroup, and matched source on address set. In that case, all node will have the same set of OVS flows, matching sources that are not scheduled on that node at all. When using port group as a source match, only flow for local ports will be present on every node. The port group is created, updated and deleted by namespace handler similar to the namespace address set. Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
The KubeVirt client is introducing k8s 1.26 as dependency and that makes bumping to k8s 1.28 impossible. This change replace the kv client with controller runtime client and the run commands is using virtctl bash command. Signed-off-by: Enrique Llorente <ellorent@redhat.com>
When a live migration fails at completed virt-launcher pod with newer creation timestamp is lingering in the system so the virt-launcher that is really running the VM is hidden by it and routes are wrongly reconstructed. This change take into account if the pod is completed to ignore it marking it as stale. Signed-off-by: Enrique Llorente <ellorent@redhat.com>
@qinqon: This pull request references Jira Issue OCPBUGS-22767, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@qinqon: This pull request references Jira Issue OCPBUGS-22767, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@qinqon: This pull request references Jira Issue OCPBUGS-22767, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/refresh jira |
/test images |
/test e2e-gcp-ovn |
5 similar comments
/test e2e-gcp-ovn |
/test e2e-gcp-ovn |
/test e2e-gcp-ovn |
/test e2e-gcp-ovn |
/test e2e-gcp-ovn |
/retest-required |
/lgtm |
/test e2e-gcp-ovn |
@qinqon: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/payload ci blocking |
/payload 4.15 blocking |
/payload 4.15 ci blocking |
@jcaamano: trigger 5 job(s) of type blocking for the ci release of OCP 4.15
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/69077ee0-8308-11ee-8ee6-dbb3af58f047-0 |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flavio-fernandes, jcaamano, npinaeva, qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0e8096f
into
openshift:master
@qinqon: Jira Issue OCPBUGS-19050: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-19050 has been moved to the MODIFIED state. Jira Issue OCPBUGS-22691: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-22691 has been moved to the MODIFIED state. Jira Issue OCPBUGS-22767: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-22767 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build ovn-kubernetes-microshift-container-v4.15.0-202311161532.p0.g0e8096f.assembly.stream for distgit ovn-kubernetes-microshift. |
Fix included in accepted release 4.15.0-0.nightly-2023-11-16-214550 |
/cc @npinaeva @jcaamano @trozet @wizhaoredhat @flavio-fernandes @lmilleri