[release-4.14] OCPBUGS-23387: Ignore completed virt-launcher pods #1954
Conversation
Signed-off-by: Enrique Llorente <ellorent@redhat.com> (cherry picked from commit a1e196f)
When a live migration fails at completed virt-launcher pod with newer creation timestamp is lingering in the system so the virt-launcher that is really running the VM is hidden by it and routes are wrongly reconstructed. This change take into account if the pod is completed to ignore it marking it as stale. Signed-off-by: Enrique Llorente <ellorent@redhat.com> (cherry picked from commit 469c4e8)
|
/jira refresh |
|
@qinqon: No Jira issue is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
qinqon
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@qinqon: This pull request references Jira Issue OCPBUGS-23387, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
|
@qinqon: This pull request references Jira Issue OCPBUGS-23387, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required |
|
/jira refresh |
|
@qinqon: This pull request references Jira Issue OCPBUGS-23387, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
/label backport-risk-assessed |
openshift-ci
bot
added
the
backport-risk-assessed
openshift-ci
bot
assigned anuragthehatter, asood-rh, huiran0826, jechen0648, mffiedler, qiowang721, rbbratta, weliang1, yingwang-0320 and zhaozhanqi
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcaamano, qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/jira refresh |
|
@dcbw: This pull request references Jira Issue OCPBUGS-23387, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@maiqueb: This pull request references Jira Issue OCPBUGS-23387, which is valid. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jechen@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
@qinqon: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 0d0b66f
into
openshift:release-4.14
|
@qinqon: Jira Issue OCPBUGS-23387: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-23387 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-ovn-kubernetes-base-container-v4.14.0-202312132033.p0.g0d0b66f.assembly.stream for distgit ovn-kubernetes-base. |
|
Fix included in accepted release 4.14.0-0.nightly-2023-12-14-000637 |
- What this PR does and why is it needed
When a live migration fails at completed virt-launcher pod with newer
creation timestamp is lingering in the system so the virt-launcher that
is really running the VM is hidden by it and routes are wrongly
reconstructed. This change take into account if the pod is completed to
ignore it marking it as stale.
closes OCPBUGS-23387
- How to verify it
It includes a unit test that emulate the result of failing migration, completed virt-launcher pod with newer creation timestamp.
- Description for the changelog
kubevirt: Ignore completed virt-launcher pods