OCPBUGS-21773: Downstream Merge 22nd November 2023 #1958
Conversation
There was additional code to handle the OVN-IC zones from the SBDB to support OVN-IC. Since the DPU-Host mode assumes that OVN does not run alongside it, the code needed to be modified to prevent accesses to the OVN DBs. Co-authored-by: Riccardo Ravaioli <rravaiol@redhat.com> Signed-off-by: William Zhao <wizhao@redhat.com>
The "GetNodePrimaryIP" does not return a CIDR address. We should pass the ifaddr from the gateway bridge. Signed-off-by: William Zhao <wizhao@redhat.com>
The commit 7dc4804 added the ovnkube-identity binary to the Fedora Dockerfiles. This patch updates the Ubuntu one. Signed-off-by: Alin-Gabriel Serdean <aserdean@ovn.org>
… version of OVN Signed-off-by: Alin-Gabriel Serdean <aserdean@ovn.org>
…e_ubuntu Dockerfile.ubuntu fixes
If GetVdpaDeviceByPci returns an error we should log the result and allow GetSriovnetOps to run instead of bailing out. This patch makes GetVdpaDeviceByPci errors non fatal. Found while testing on a ConnectX environment. Signed-off-by: Alin-Gabriel Serdean <aserdean@ovn.org>
…bug_fixes Dpu OVN-IC enablement
We should not fail silently if a pod is running on a node that does not exist Signed-off-by: Ben Pickard <bpickard@redhat.com>
Signed-off-by: Ben Pickard <bpickard@redhat.com>
Running make check as root on Ubuntu 22.04, make complains with the following:
/go/src/github.com/ovn-org/ovn-kubernetes/go-controller/pkg/node/gateway_init_linux_test.go:1387 [42/9265] sets up a shared interface gateway DPU host
/go/src/github.com/ovn-org/ovn-kubernetes/go-controller/pkg/testing/testing.go:18
Unexpected error:
<*errors.errorString | 0xc000c0be50>:
mount --make-rshared /var/run/netns failed: "permission denied"
{
s: "mount --make-rshared /var/run/netns failed: \"permission denied\"",
}
occurred
This patch runs container in privileged mode to overcome all permissions.
Signed-off-by: Alin-Gabriel Serdean <aserdean@ovn.org>
go-controller/Makefile: Fix make check on Ubuntu
sriovnet_linux: Make GetVdpaDeviceByPci errors non fatal
Ignore pod allocation errors during sync if no node exists
the OpenShift that using OVN network should be starting from version 4.10 Signed-off-by: krescent <c54444263@gmail.com>
Update INSTALL.OPENSHIFT.md
…e-node in DPU mode ovn_enable_ovnkube_identity is enabled by default for all modes of ovnkube-node. This patch allows the user to disable ovn_enable_ovnkube_identity in ovnkube-node-dpu-host. Signed-off-by: Alin-Gabriel Serdean <aserdean@ovn.org>
While testing I found that ovnkube-node-dpu-host can't set the required pod annotations because it was lacking permissions. Signed-off-by: Alin-Gabriel Serdean <aserdean@ovn.org>
…ss of success of failure Signed-off-by: jordigilh <jgil@redhat.com>
/usr/sbin/iptables is the de facto path for iptables in most distributions. Notably, since kind switched to Debian 11-based images, ovn-kubernetes fails to deploy there because Debian 11 provides iptables *only* in /usr/sbin. On Ubuntu and Fedora, /sbin and /usr/sbin are the same directory, so iptables is available in both location and nothing changes there. Debian 12 and later also have the same setup. Signed-off-by: Stephen Kitt <skitt@redhat.com>
Use /usr/sbin/iptables instead of /sbin/iptables
Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
Use /usr/sbin/iptables6 instead of /sbin/iptables6
Signed-off-by: Jose Castillo Lema <josecastillolema@gmail.com>
This commit makes default network controller to wait for Encap entry to be created because in some cases local node add event is received a bit later than network controller and it looks up for encap entry and giving up on starting ovnkube controller. Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
…atic hop IP field Signed-off-by: Jordi Gil <jgil@redhat.com>
Fix templating around ovnkube-node-dpu-host
openshift-ci-robot
added
jira/severity-important
openshift-ci-robot
added
the
jira/invalid-bug
|
@pperiyasamy: This pull request references Jira Issue OCPBUGS-21773, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
|
@pperiyasamy: GitHub didn't allow me to request PR reviews from the following users: aserdean. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
|
@pperiyasamy: This pull request references Jira Issue OCPBUGS-21773, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (yli2@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/retest-required |
|
@pperiyasamy: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
dcbw
added
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: pperiyasamy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 6ec3f5c
into
openshift:master
|
@pperiyasamy: Jira Issue OCPBUGS-21773: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-21773 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-ovn-kubernetes-base-container-v4.15.0-202311271609.p0.g6ec3f5c.assembly.stream for distgit ovn-kubernetes-base. |
|
Fix included in accepted release 4.15.0-0.nightly-2023-11-28-101923 |
|
Fix included in accepted release 4.15.0-0.nightly-2023-12-02-123536 |
/cc @wizhaoredhat @ricky-rav @aserdean @trozet @bpickard22 @jordigilh @skitt @jcaamano @dcbw @tssurya