OCPBUGS-24014: Downstream merge 28th November 2023 #1962

dcbw · 2023-11-28T14:41:11Z

Really just pulls in ovn-org/ovn-kubernetes#4012 and an improvement related to openshift/machine-config-operator#4040

The previous ${interface}:vip label on keepalived addresses yielded an error whenever the total label length exceeded the allowed limit of 15 characters. As a result, we simplified the label to be just "vip", which is sufficient for our purposes: openshift/machine-config-operator#4040 Let's keep the call to "HasSuffix" to be compatible with both implementations. Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>

kubernetes/kubernetes#118455 Kubernetes-commit: c86f562f29b6b7498ea962d2ac596e6d26ecd723 Kubernetes-commit: 9c4651bd0479b84f5e5913649207476717f3f13e Signed-off-by: Eric Lin <exlin@google.com>

We don't care about them, so why cache them and use a ton of memory. Inspired by kubernetes/kubernetes#118455 Signed-off-by: Dan Williams <dcbw@redhat.com>

…thRetry() function Signed-off-by: Dan Williams <dcbw@redhat.com>

Significantly reduce shared informer memory usage

openshift-ci-robot · 2023-11-28T14:41:16Z

@dcbw: This pull request references Jira Issue OCPBUGS-24014, which is invalid:

expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dcbw · 2023-11-28T14:42:27Z

/jira refresh

openshift-ci-robot · 2023-11-28T14:42:31Z

@dcbw: This pull request references Jira Issue OCPBUGS-24014, which is invalid:

expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dcbw · 2023-11-28T14:43:12Z

/jira refresh

openshift-ci-robot · 2023-11-28T14:43:21Z

@dcbw: This pull request references Jira Issue OCPBUGS-24014, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.15.0) matches configured target version for branch (4.15.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-11-28T14:44:05Z

@dcbw: This pull request references Jira Issue OCPBUGS-24014, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.15.0) matches configured target version for branch (4.15.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

Really just pulls in ovn-org/ovn-kubernetes#4012 and an improvement related to openshift/machine-config-operator#4040

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dcbw · 2023-11-28T21:09:56Z

/retest-required

dcbw · 2023-11-28T21:10:40Z

/test e2e-azure-ovn

"errorMessage": "Query was throttled with reason: ServerBusy. Requested Metric:AzComputeShoeboxCUS|Shoebox|OS Disk Queue Depth. Output Dimensions: . Dimension Filters: microsoft.resourceGroupName,microsoft.resourceId,microsoft.resourceType,microsoft.subscriptionId. RequestedSamplingType: Count,Sum,NullableAverage. Start time: 11/28/2023 3:45:27 PM End time: 11/28/2023 4:44:27 PM. Resolution: 00:01:00, Last Value Mode: False. Context:MetricsMP, CustomerId:Unknown. TraceID:{a7cbaa9e-d881-48b5-a8c6-8b2eaf369723};AzSubId=d38f1e38-4bed-438e-b227-833f997adf6a;AzResType=Microsoft.Compute/virtualMachines;AzRegion=centralus;, IsUserQuery:1, ClientTimeout:00:01:40, ClientName:GatewayService-API->QueryServiceCoordinator, ElapsedTime(ms):0, Exception:Microsoft.Online.QueryService.Contracts.QueryThrottledException: Query service is overloaded and is not accepting new queries at this time: too many queries in flight.\r\n   at Microsoft.Online.Metrics.QueryServiceCoordinator.Throttling.QueryCapacityThrottlingManager.CheckCapacity(String clientName, Boolean throttlingBypassMode, Boolean isPercentileGroupByQuery, Boolean isDistinctCountGroupByQuery) in D:\\dbs\\sh\\acem\\1019_131421_0\\cmd\\l\\src\\QueryService\\QueryServiceCoordinator\\Throttling\\QueryCapacityThrottlingManager.cs:line 106\r\n   at Microsoft.Online.Metrics.QueryServiceCoordinator.QueryCoordinator.<ExecuteAsync>d__51.MoveNext() in D:\\dbs\\sh\\acem\\1019_131421_0\\cmd\\l\\src\\QueryService\\QueryServiceCoordinator\\QueryCoordinator.cs:line 420.",

openshift-ci · 2023-11-29T00:02:58Z

@dcbw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-kubevirt	`fbccc9b`	link	false	`/test e2e-aws-ovn-kubevirt`
ci/prow/security	`fbccc9b`	link	false	`/test security`
ci/prow/e2e-azure-ovn	`fbccc9b`	link	false	`/test e2e-azure-ovn`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

flavio-fernandes · 2023-11-29T15:20:42Z

/lgtm

compared against upstream
git checkout 0384de6421c729b34f5c5a7544c5847d48a9cd2d

flavio-fernandes · 2023-11-29T15:22:37Z

/lgtm

flavio-fernandes · 2023-11-29T15:24:41Z

/shrug

openshift-ci-robot · 2023-11-29T15:38:10Z

@dcbw: Jira Issue OCPBUGS-24014: All pull requests linked via external trackers have merged:

openshift/ovn-kubernetes#1962

Jira Issue OCPBUGS-24014 has been moved to the MODIFIED state.

In response to this:

Really just pulls in ovn-org/ovn-kubernetes#4012 and an improvement related to openshift/machine-config-operator#4040

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-11-29T15:38:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, flavio-fernandes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [dcbw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2023-11-29T15:40:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, flavio-fernandes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [dcbw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2023-11-30T03:31:42Z

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-ovn-kubernetes-base-container-v4.15.0-202311300249.p0.g3906c6b.assembly.stream for distgit ovn-kubernetes-base.
All builds following this will include this PR.

openshift-merge-robot · 2023-12-02T17:55:49Z

Fix included in accepted release 4.15.0-0.nightly-2023-12-02-123536

ricky-rav and others added 6 commits November 22, 2023 17:32

CARRY: Add 'WithTransform' SharedInformerOption

aa4b720

kubernetes/kubernetes#118455 Kubernetes-commit: c86f562f29b6b7498ea962d2ac596e6d26ecd723 Kubernetes-commit: 9c4651bd0479b84f5e5913649207476717f3f13e Signed-off-by: Eric Lin <exlin@google.com>

factory: strip Managed Fields and some Pod fields to reduce memory usage

7198fad

We don't care about them, so why cache them and use a ton of memory. Inspired by kubernetes/kubernetes#118455 Signed-off-by: Dan Williams <dcbw@redhat.com>

ovn: remove unused CommonNetworkControllerInfo UpdateNodeAnnotationWi…

51fc946

…thRetry() function Signed-off-by: Dan Williams <dcbw@redhat.com>

Merge pull request #4012 from dcbw/save-informer-memory

ac6820d

Significantly reduce shared informer memory usage

Merge remote-tracking branch 'ovnorg/master'

fbccc9b

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 28, 2023

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 28, 2023

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 28, 2023

openshift-ci bot requested review from jcaamano and trozet November 28, 2023 14:47

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2023

openshift-ci bot added the ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ label Nov 29, 2023

openshift-ci bot assigned flavio-fernandes Nov 29, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2023

openshift-merge-bot bot merged commit 3906c6b into openshift:master Nov 29, 2023
27 of 30 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-24014: Downstream merge 28th November 2023 #1962

OCPBUGS-24014: Downstream merge 28th November 2023 #1962

dcbw commented Nov 28, 2023 •

edited

openshift-ci-robot commented Nov 28, 2023

dcbw commented Nov 28, 2023

openshift-ci-robot commented Nov 28, 2023

dcbw commented Nov 28, 2023

openshift-ci-robot commented Nov 28, 2023

openshift-ci-robot commented Nov 28, 2023

dcbw commented Nov 28, 2023

dcbw commented Nov 28, 2023

openshift-ci bot commented Nov 29, 2023

flavio-fernandes commented Nov 29, 2023

flavio-fernandes commented Nov 29, 2023

flavio-fernandes commented Nov 29, 2023

openshift-ci-robot commented Nov 29, 2023

openshift-ci bot commented Nov 29, 2023

openshift-ci bot commented Nov 29, 2023

openshift-bot commented Nov 30, 2023

openshift-merge-robot commented Dec 2, 2023

OCPBUGS-24014: Downstream merge 28th November 2023 #1962

OCPBUGS-24014: Downstream merge 28th November 2023 #1962

Conversation

dcbw commented Nov 28, 2023 • edited

openshift-ci-robot commented Nov 28, 2023

dcbw commented Nov 28, 2023

openshift-ci-robot commented Nov 28, 2023

dcbw commented Nov 28, 2023

openshift-ci-robot commented Nov 28, 2023

openshift-ci-robot commented Nov 28, 2023

dcbw commented Nov 28, 2023

dcbw commented Nov 28, 2023

openshift-ci bot commented Nov 29, 2023

flavio-fernandes commented Nov 29, 2023

flavio-fernandes commented Nov 29, 2023

flavio-fernandes commented Nov 29, 2023

openshift-ci-robot commented Nov 29, 2023

openshift-ci bot commented Nov 29, 2023

openshift-ci bot commented Nov 29, 2023

openshift-bot commented Nov 30, 2023

openshift-merge-robot commented Dec 2, 2023

dcbw commented Nov 28, 2023 •

edited