Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-24322,OCPBUGS-25357: Dockerfile: Bump OVN to ovn-23.09.0-91.el9fdp #1986

Conversation

dceara
Copy link
Contributor

@dceara dceara commented Dec 12, 2023

Includes the following relevant changes:

  • Fix for potential crash in ovn-northd while incrementally processing load balancer changes FDP-181 OCPBUGS-24322

  • Support more than 64K OF groups/meters to allow scaling to more than 32K services FDP-70

  • Add missing conntrack flushing support (for LBs on logical routers) rhbz#2193323

  • Fix for incorrect source IP in ICMP needsfrag FDP-39 OCPBUGS-25357

  • Fix for check_pkt_larger calculation when tag_request is set to 0 FDP-38

@dceara dceara requested a review from dcbw as a code owner December 12, 2023 10:38
@openshift-ci openshift-ci bot requested a review from abhat December 12, 2023 10:41
@dceara
Copy link
Contributor Author

dceara commented Dec 12, 2023

CC: @dcbw @trozet @tssurya @flavio-fernandes

Fix for incorrect source IP in ICMP needsfrag [https://issues.redhat.com/browse/FDP-39]
[https://issues.redhat.com/browse/OCPBUGS-18467]

Should we wait for https://patchwork.ozlabs.org/project/ovn/list/?series=385469&state=*, the fix from @almusil for unSNAT ICMP needs frag not working with OVN-Kubernetes too? I assume we don't have to as there's already #1969 in place.

@flavio-fernandes
Copy link
Contributor

/retest-required

@flavio-fernandes
Copy link
Contributor

/retitle OCPBUGS-24322: Dockerfile: Bump OVN to ovn-23.09.0-88.el9fdp

@openshift-ci openshift-ci bot changed the title Dockerfile: Bump OVN to ovn-23.09.0-88.el9fdp OCPBUGS-24322: Dockerfile: Bump OVN to ovn-23.09.0-88.el9fdp Dec 12, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 12, 2023
@openshift-ci-robot
Copy link
Contributor

@dceara: This pull request references Jira Issue OCPBUGS-24322, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Includes the following relevant changes:

  • Fix for potential crash in ovn-northd while incrementally processing load balancer changes [https://issues.redhat.com/browse/FDP-181] [https://issues.redhat.com/browse/OCPBUGS-24322]

  • Support for PMTUD on tunnel ports [https://bugzilla.redhat.com/show_bug.cgi?id=2241711]

  • Support more than 64K OF groups/meters to allow scaling to more than 32K services [https://issues.redhat.com/browse/FDP-70]

  • Add missing conntrack flushing support (for LBs on logical routers) [https://bugzilla.redhat.com/show_bug.cgi?id=2193323]

  • Fix for incorrect source IP in ICMP needsfrag [https://issues.redhat.com/browse/FDP-39] [https://issues.redhat.com/browse/OCPBUGS-18467]

  • Fix for check_pkt_larger calculation when tag_request is set to 0 [https://issues.redhat.com/browse/FDP-38]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@flavio-fernandes
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Dec 12, 2023
@openshift-ci-robot
Copy link
Contributor

@flavio-fernandes: This pull request references Jira Issue OCPBUGS-24322, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 12, 2023
@dceara
Copy link
Contributor Author

dceara commented Dec 12, 2023

/retitle OCPBUGS-24322: Dockerfile: Bump OVN to ovn-23.09.0-88.el9fdp

@flavio-fernandes Hmm, there's a bunch of other OCP reported bugs we're fixing with this. Why choose only 24322?

@flavio-fernandes
Copy link
Contributor

/retitle OCPBUGS-24322: Dockerfile: Bump OVN to ovn-23.09.0-88.el9fdp

@flavio-fernandes Hmm, there's a bunch of other OCP reported bugs we're fixing with this. Why choose only 24322?

@dceara that is me being ignorant about the others. Please retitle all the ones you want represented here, using commas:

OCPBUGS-XXX,OCPBUGS-YYY,OCPBUGS-ZZZ: Dockerfile: Bump OVN to ovn-23.09.0-88.el9fdp

@flavio-fernandes
Copy link
Contributor

/test e2e-aws-ovn

@flavio-fernandes
Copy link
Contributor

/cherry-pick release-4.15

@openshift-cherrypick-robot

@flavio-fernandes: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dceara
Copy link
Contributor Author

dceara commented Dec 12, 2023

The RPM mirrors are not updated yet I guess:

Error: Unable to find a match: ovn23.09 = 23.09.0-88.el9fdp ovn23.09-central = 23.09.0-88.el9fdp ovn23.09-host = 23.09.0-88.el9fdp

@dceara
Copy link
Contributor Author

dceara commented Dec 12, 2023

/retitle OCPBUGS-24322,OCPBUGS-18467: Dockerfile: Bump OVN to ovn-23.09.0-88.el9fdp

@openshift-ci openshift-ci bot changed the title OCPBUGS-24322: Dockerfile: Bump OVN to ovn-23.09.0-88.el9fdp OCPBUGS-24322,OCPBUGS-18467: Dockerfile: Bump OVN to ovn-23.09.0-88.el9fdp Dec 12, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Dec 12, 2023
@openshift-ci-robot
Copy link
Contributor

@dceara: This pull request references Jira Issue OCPBUGS-24322, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-18467, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to target either version "4.16." or "openshift-4.16.", but it targets "4.14.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Done-Errata) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Includes the following relevant changes:

  • Fix for potential crash in ovn-northd while incrementally processing load balancer changes [https://issues.redhat.com/browse/FDP-181] [https://issues.redhat.com/browse/OCPBUGS-24322]

  • Support for PMTUD on tunnel ports [https://bugzilla.redhat.com/show_bug.cgi?id=2241711]

  • Support more than 64K OF groups/meters to allow scaling to more than 32K services [https://issues.redhat.com/browse/FDP-70]

  • Add missing conntrack flushing support (for LBs on logical routers) [https://bugzilla.redhat.com/show_bug.cgi?id=2193323]

  • Fix for incorrect source IP in ICMP needsfrag [https://issues.redhat.com/browse/FDP-39] [https://issues.redhat.com/browse/OCPBUGS-18467]

  • Fix for check_pkt_larger calculation when tag_request is set to 0 [https://issues.redhat.com/browse/FDP-38]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dceara
Copy link
Contributor Author

dceara commented Dec 12, 2023

/test images

@trozet
Copy link
Contributor

trozet commented Dec 12, 2023

/hold

while we try to debug issues with ICMP needs frag

@trozet
Copy link
Contributor

trozet commented Dec 14, 2023

Looks like there is a regression here with tunnel PMTUD support: ovn-org/ovn-kubernetes#4039 (comment)

@flavio-fernandes
Copy link
Contributor

/lgtm cancel

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2023
@tssurya
Copy link
Contributor

tssurya commented Dec 18, 2023

/hold

@dceara
Copy link
Contributor Author

dceara commented Dec 18, 2023

We're reverting the patch that introduced the PMTUD regression. I'll update the PR as soon as that patch will be available in an ovn23.09 build.

@dceara dceara force-pushed the OCPBUGS-24322-bump-ovn-23.09.0-88.el9fdp branch from 2318e3b to adef345 Compare December 18, 2023 20:40
@dceara dceara changed the title OCPBUGS-24322,OCPBUGS-25357: Dockerfile: Bump OVN to ovn-23.09.0-88.el9fdp OCPBUGS-24322,OCPBUGS-25357: Dockerfile: Bump OVN to ovn-23.09.0-91.el9fdp Dec 18, 2023
Includes the following relevant changes:

- Fix for potential crash in ovn-northd while incrementally processing
  load balancer changes
  [https://issues.redhat.com/browse/FDP-181]
  [https://issues.redhat.com/browse/OCPBUGS-24322]

- Support more than 64K OF groups/meters to allow scaling to more than
  32K services
  [https://issues.redhat.com/browse/FDP-70]

- Add missing conntrack flushing support (for LBs on logical routers)
  [https://bugzilla.redhat.com/show_bug.cgi?id=2193323]

- Fix for incorrect source IP in ICMP needsfrag
  [https://issues.redhat.com/browse/FDP-39]
  [https://issues.redhat.com/browse/OCPBUGS-25357]

- Fix for check_pkt_larger calculation when tag_request is set to 0
  [https://issues.redhat.com/browse/FDP-38]

Signed-off-by: Dumitru Ceara <dceara@redhat.com>
@dceara dceara force-pushed the OCPBUGS-24322-bump-ovn-23.09.0-88.el9fdp branch from adef345 to 5beb671 Compare December 18, 2023 20:43
@flavio-fernandes
Copy link
Contributor

/retest-required

1 similar comment
@flavio-fernandes
Copy link
Contributor

/retest-required

@dceara
Copy link
Contributor Author

dceara commented Dec 19, 2023

/retest

@dceara
Copy link
Contributor Author

dceara commented Dec 19, 2023

/test e2e-aws-ovn

@dceara
Copy link
Contributor Author

dceara commented Dec 19, 2023

/retest

@trozet
Copy link
Contributor

trozet commented Dec 19, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 19, 2023
@trozet
Copy link
Contributor

trozet commented Dec 19, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2023
Copy link
Contributor

openshift-ci bot commented Dec 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, dceara, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dceara
Copy link
Contributor Author

dceara commented Dec 19, 2023

/retest

{  could not create snapshot imagestream ocp/4.16 for release latest: Timeout: request did not complete within requested timeout - context deadline exceeded}

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 2c98ee2 and 2 for PR HEAD 5beb671 in total

@dceara
Copy link
Contributor Author

dceara commented Dec 19, 2023

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 447d9b4 into openshift:master Dec 20, 2023
25 of 30 checks passed
@openshift-ci-robot
Copy link
Contributor

@dceara: Jira Issue OCPBUGS-24322: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-24322 has been moved to the MODIFIED state.

Jira Issue OCPBUGS-25357: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-25357 has been moved to the MODIFIED state.

In response to this:

Includes the following relevant changes:

  • Fix for potential crash in ovn-northd while incrementally processing load balancer changes FDP-181 OCPBUGS-24322

  • Support more than 64K OF groups/meters to allow scaling to more than 32K services FDP-70

  • Add missing conntrack flushing support (for LBs on logical routers) rhbz#2193323

  • Fix for incorrect source IP in ICMP needsfrag FDP-39 OCPBUGS-25357

  • Fix for check_pkt_larger calculation when tag_request is set to 0 FDP-38

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Dec 20, 2023

@dceara: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-gcp-ovn 5beb671 link false /test okd-e2e-gcp-ovn
ci/prow/security 5beb671 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-cherrypick-robot

@flavio-fernandes: new pull request created: #1994

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-ovn-kubernetes-base-container-v4.16.0-202312200132.p0.g447d9b4.assembly.stream for distgit ovn-kubernetes-base.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants