[WIP] proxy terminating endpoints #2008
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ricky-rav The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ricky-rav
force-pushed
the
OCPBUGS-24363-416
branch
4 times, most recently
from
fc340d6
to
125eace
Compare
|
/retest |
1 similar comment
|
/retest |
The previous implementation was an approximation of KEP-1669 ProxyTerminatingEndpoints: we simply included terminating serving endpoints (ready=false, serving=true, terminating=true) along with ready ones in the endpoint selection logic. Let's fully implement KEP-1669 and only include terminating endpoints if none are ready. The selection follows two simple steps: 1) Take all ready endpoints 2) If no ready endpoints were found, take all serving terminating endpoints. This should also help with an issue found in a production cluster (https://issues.redhat.com/browse/OCPBUGS-24363) where, due to infrequent readiness probes, terminating endpoints were declared as non-serving (that is, their readiness probe failed) only quite late and were included as valid endpoints for quite a bit, while the existing ready endpoints should have been preferred. Extended the test cases to include testing against multiple slices and dual stack scenarios. Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com> (cherry picked from commit 35b1ae810f38007aa78556ba1badc18e293bea1e)
ricky-rav
force-pushed
the
OCPBUGS-24363-416
branch
from
125eace
to
eca0c43
Compare
|
@ricky-rav: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
No description provided.