Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.14] OCPBUGS-27256: Ensure session affinity cleanup on backend removal #2021

Merged
merged 2 commits into from Jan 31, 2024
Merged

[release-4.14] OCPBUGS-27256: Ensure session affinity cleanup on backend removal #2021

merged 2 commits into from Jan 31, 2024

Conversation

npinaeva
Copy link
Member

@npinaeva npinaeva commented Jan 17, 2024 •
edited

backport of #2020
Conflicts:
test/e2e/service.go - switched to the ancient test framework version

npinaeva and others added 2 commits January 17, 2024 12:30
@npinaeva
Add e2e test for session affinity after the chosen backend pod is
ceb7183 
deleted.

Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
(cherry picked from commit 24f9357)
(cherry picked from commit 5c4c45c)

Conflicts:
test/e2e/service.go - switched to the ancient test framework version
@dceara @npinaeva
Dockerfile: Bump OVN to ovn-23.09.0-100.el9fdp
dfe036d 
Includes the following relevant change:
- Make sure affinity learnt flows are auto deleted.
  [https://issues.redhat.com/browse/OCPBUGS-26023]
  [https://issues.redhat.com/browse/FDP-257]

Signed-off-by: Dumitru Ceara <dceara@redhat.com>
(cherry picked from commit b3e0f9d)
(cherry picked from commit d84fe14)
(cherry picked from commit 8185be7)
@npinaeva npinaeva requested a review from dcbw as a code owner January 17, 2024 11:33
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 17, 2024
@openshift-ci-robot
Copy link
Contributor

@npinaeva: This pull request references Jira Issue OCPBUGS-27256, which is invalid:

  • expected dependent Jira Issue OCPBUGS-27255 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

backport of #2020

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from abhat and jcaamano January 17, 2024 11:34
@npinaeva npinaeva mentioned this pull request Jan 17, 2024
Merged
@npinaeva
Copy link
Member Author

/retest-required

@npinaeva
Copy link
Member Author

/payload 4.14 ci blocking
/payload 4.14 nightly blocking

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 17, 2024

@npinaeva: trigger 5 job(s) of type blocking for the ci release of OCP 4.14

  • periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.14-e2e-aws-sdn-serial
  • periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-azure-sdn-upgrade
  • periodic-ci-openshift-release-master-ci-4.14-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cf03e190-b560-11ee-9f21-60d73259aa87-0

trigger 8 job(s) of type blocking for the nightly release of OCP 4.14

  • periodic-ci-openshift-release-master-nightly-4.14-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.14-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.14-e2e-aws-sdn-upgrade
  • periodic-ci-openshift-release-master-ci-4.14-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.14-e2e-metal-ipi-ovn-ipv6
  • periodic-ci-openshift-release-master-nightly-4.14-e2e-metal-ipi-sdn-bm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cf03e190-b560-11ee-9f21-60d73259aa87-1

@jechen0648
Copy link

/ocpbugs cc-qa

@jechen0648
Copy link

/label qe-approved

@jechen0648
Copy link

/test e2e-aws-ovn-serial

@jechen0648
Copy link

/test security

@mffiedler
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 17, 2024
@npinaeva
Copy link
Member Author

/retest-required

@npinaeva
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 29, 2024
@openshift-ci-robot
Copy link
Contributor

@npinaeva: This pull request references Jira Issue OCPBUGS-27256, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-27255 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-27255 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jechen@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

trozet
trozet approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@trozet trozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 29, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: npinaeva, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD b050c8f and 2 for PR HEAD dfe036d in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 09ddd42 and 1 for PR HEAD dfe036d in total

@npinaeva
Copy link
Member Author

/retest-required

1 similar comment
@npinaeva
Copy link
Member Author

/retest-required

@mffiedler
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 31, 2024
@openshift-ci-robot openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 31, 2024
@openshift-ci-robot
Copy link
Contributor

@npinaeva: This pull request references Jira Issue OCPBUGS-27256, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

backport of #2020
Conflicts:
test/e2e/service.go - switched to the ancient test framework version

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mffiedler
Copy link

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@mffiedler: This pull request references Jira Issue OCPBUGS-27256, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcaamano
Copy link
Contributor

/override ci/prow/4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade
/override ci/prow/e2e-metal-ipi-ovn-dualstack
/override ci/prow/e2e-vsphere-windows

All of these jobs have passed previously. The ipv6 and vsphere failures are infra issues.

@npinaeva
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@npinaeva: This pull request references Jira Issue OCPBUGS-27256, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@npinaeva
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 31, 2024
@openshift-ci-robot
Copy link
Contributor

@npinaeva: This pull request references Jira Issue OCPBUGS-27256, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-27255 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-27255 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jechen@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcaamano
Copy link
Contributor

/override ci/prow/4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade
/override ci/prow/e2e-metal-ipi-ovn-dualstack
/override ci/prow/e2e-vsphere-windows

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 31, 2024

@jcaamano: Overrode contexts on behalf of jcaamano: ci/prow/4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade, ci/prow/e2e-metal-ipi-ovn-dualstack, ci/prow/e2e-vsphere-windows

In response to this:

/override ci/prow/4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade
/override ci/prow/e2e-metal-ipi-ovn-dualstack
/override ci/prow/e2e-vsphere-windows

All of these jobs have passed previously. The ipv6 and vsphere failures are infra issues.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 3b0c69d into openshift:release-4.14 Jan 31, 2024
27 of 28 checks passed
@openshift-ci-robot
Copy link
Contributor

@npinaeva: Jira Issue OCPBUGS-27256: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-27256 has been moved to the MODIFIED state.

In response to this:

backport of #2020
Conflicts:
test/e2e/service.go - switched to the ancient test framework version

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@npinaeva npinaeva deleted the ocpbugs-27256 branch January 31, 2024 18:33
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 31, 2024

@jcaamano: Overrode contexts on behalf of jcaamano: ci/prow/4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade, ci/prow/e2e-metal-ipi-ovn-dualstack, ci/prow/e2e-vsphere-windows

In response to this:

/override ci/prow/4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade
/override ci/prow/e2e-metal-ipi-ovn-dualstack
/override ci/prow/e2e-vsphere-windows

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 31, 2024

@npinaeva: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security dfe036d link false /test security
ci/prow/e2e-metal-ipi-ovn-dualstack dfe036d link unknown /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-vsphere-windows dfe036d link unknown /test e2e-vsphere-windows

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-ovn-kubernetes-base-container-v4.14.0-202402010409.p0.g3b0c69d.assembly.stream for distgit ovn-kubernetes-base.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trozet trozet trozet approved these changes

@dcbw dcbw Awaiting requested review from dcbw

@abhat abhat Awaiting requested review from abhat

@jcaamano jcaamano Awaiting requested review from jcaamano

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@zhaozhanqi zhaozhanqi

@weliang1 weliang1

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@yingwang-0320 yingwang-0320

@qiowang721 qiowang721

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet