Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-28848: Ignore hybrid-overlay nodes from EgressIP controller #2040

Merged
merged 1 commit into from Feb 7, 2024
Merged

OCPBUGS-28848: Ignore hybrid-overlay nodes from EgressIP controller #2040

merged 1 commit into from Feb 7, 2024

Conversation

kyrtapz
Copy link
Contributor

@kyrtapz kyrtapz commented Jan 31, 2024

Clean cherry pick from 63641aa

@kyrtapz
Ignore hybrid-overlay nodes from EgressIP controller
b04f276 
EgressIP is not supported on hybrid-overlay nodes.
Exclude hybrid-overlay nodes from EgressIP controller to avoid
issues related to missing annotations.

Signed-off-by: Patryk Diak <pdiak@redhat.com>
(cherry picked from commit 63641aa)
@kyrtapz kyrtapz requested a review from dcbw as a code owner January 31, 2024 12:49
@kyrtapz
Copy link
Contributor Author

kyrtapz commented Jan 31, 2024

/jira-cherry-pick OCPBUGS-23430

@openshift-ci openshift-ci bot requested a review from tssurya January 31, 2024 12:56
@kyrtapz
Copy link
Contributor Author

kyrtapz commented Jan 31, 2024

/jira-cherry-pick OCPBUGS-23430

@kyrtapz
Copy link
Contributor Author

kyrtapz commented Feb 1, 2024

/jira cherry-pick OCPBUGS-23430

@openshift-ci-robot
Copy link
Contributor

@kyrtapz: Jira Issue OCPBUGS-23430 has been cloned as Jira Issue OCPBUGS-28848. Will retitle bug to link to clone.
/retitle OCPBUGS-28848: Ignore hybrid-overlay nodes from EgressIP controller

In response to this:

/jira cherry-pick OCPBUGS-23430

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title Ignore hybrid-overlay nodes from EgressIP controller OCPBUGS-28848: Ignore hybrid-overlay nodes from EgressIP controller Feb 1, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Feb 1, 2024
@openshift-ci-robot
Copy link
Contributor

@kyrtapz: This pull request references Jira Issue OCPBUGS-28848, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-23430 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-23430 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Clean cherry pick from 63641aa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kyrtapz
Copy link
Contributor Author

kyrtapz commented Feb 1, 2024

@tssurya ptal as you approved the initial change

@kyrtapz
Copy link
Contributor Author

kyrtapz commented Feb 2, 2024

/retest-required

@jechen0648
Copy link

/ocpbugs cc-qa

@jechen0648
Copy link

/label qe-approved

@kyrtapz
Copy link
Contributor Author

kyrtapz commented Feb 5, 2024

/cherry-pick release-4.14

@openshift-cherrypick-robot
Copy link

@kyrtapz: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tssurya
tssurya approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@tssurya tssurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/label backport-risk-assessed
ditto same as 63641aa

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 6, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyrtapz, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2024
@tssurya
Copy link
Contributor

tssurya commented Feb 6, 2024 •
edited

@kyrtapz : Do you have a user waiting for this fix? Why are we backporting this to 4.14? we do not backport by default. from what i can see this is a QE bug and we have like 10 users using windows (I have personally not even seen that many bugs being opened.)?

@zhaozhanqi
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 6, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD e61d7ef and 2 for PR HEAD b04f276 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 6a4ea84 and 1 for PR HEAD b04f276 in total

@kyrtapz
Copy link
Contributor Author

kyrtapz commented Feb 7, 2024

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 7, 2024 •
edited

@kyrtapz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security b04f276 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyrtapz
Copy link
Contributor Author

kyrtapz commented Feb 7, 2024

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit 2a2d873 into openshift:release-4.15 Feb 7, 2024
29 of 30 checks passed
@openshift-ci-robot
Copy link
Contributor

@kyrtapz: Jira Issue OCPBUGS-28848: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-28848 has been moved to the MODIFIED state.

In response to this:

Clean cherry pick from 63641aa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link

@kyrtapz: new pull request created: #2058

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 7, 2024
Closed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-ovn-kubernetes-base-container-v4.15.0-202402080306.p0.g2a2d873.assembly.stream.el9 for distgit ovn-kubernetes-base.
All builds following this will include this PR.

@kyrtapz kyrtapz mentioned this pull request Feb 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tssurya tssurya tssurya approved these changes

@dcbw dcbw Awaiting requested review from dcbw

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@zhaozhanqi zhaozhanqi

@weliang1 weliang1

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@yingwang-0320 yingwang-0320

@qiowang721 qiowang721

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet