Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-28819: Support Permanent Session Affinity #2046

Merged
merged 4 commits into from Feb 15, 2024
Merged

OCPBUGS-28819: Support Permanent Session Affinity #2046

merged 4 commits into from Feb 15, 2024

Conversation

tssurya
Copy link
Contributor

@tssurya tssurya commented Feb 1, 2024

CLEAN Cherry-pick of #2045

@tssurya tssurya requested a review from dcbw as a code owner February 1, 2024 12:06
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Feb 1, 2024
@openshift-ci-robot
Copy link
Contributor

@tssurya: This pull request references Jira Issue OCPBUGS-28819, which is invalid:

  • expected dependent Jira Issue OCPBUGS-28818 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead
  • expected dependent Jira Issue OCPBUGS-28818 to target a version in 4.15.0, but it targets "4.15.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

CLEAN Cherry-pick of #2045

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 1, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2024
@tssurya
Copy link
Contributor Author

tssurya commented Feb 5, 2024

/test 4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade

@tssurya
Copy link
Contributor Author

tssurya commented Feb 5, 2024

sample failure: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_ovn-kubernetes/2046/pull-ci-openshift-ovn-kubernetes-release-4.14-4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade/1753027061854769152


: [sig-network-edge] ns/openshift-console route/console disruption/ingress-to-console connection/new should be available throughout the test expand_less	0s
{  backend-disruption-name/ingress-to-console-new-connections connection/new disruption/openshift-tests namespace/openshift-console route/console was unreachable during disruption:  for at least 3s (maxAllowed=2s):

Feb 01 14:07:58.149 - 1s    E backend-disruption-name/ingress-to-console-new-connections connection/new disruption/openshift-tests namespace/openshift-console route/console reason/DisruptionBegan request-audit-id/aefd37be-f145-4b21-aefe-f163ca656402 backend-disruption-name/ingress-to-console-new-connections connection/new disruption/openshift-tests namespace/openshift-console route/console stopped responding to GET requests over new connections: Get "https://console-openshift-console.apps.ci-op-08lhviwy-8964d.origin-ci-int-aws.dev.rhcloud.com/healthz": EOF
Feb 01 14:19:11.150 - 1s    E backend-disruption-name/ingress-to-console-new-connections connection/new disruption/openshift-tests namespace/openshift-console route/console reason/DisruptionBegan request-audit-id/38eb7bea-df47-41b9-b333-f420234d03be backend-disruption-name/ingress-to-console-new-connections connection/new disruption/openshift-tests namespace/openshift-console route/console stopped responding to GET requests over new connections: Get "https://console-openshift-console.apps.ci-op-08lhviwy-8964d.origin-ci-int-aws.dev.rhcloud.com/healthz": EOF
Feb 01 14:27:19.150 - 999ms E backend-disruption-name/ingress-to-console-new-connections connection/new disruption/openshift-tests namespace/openshift-console route/console reason/DisruptionBegan request-audit-id/861668c0-a04b-4d72-b894-3258d04aa601 backend-disruption-name/ingress-to-console-new-connections connection/new disruption/openshift-tests namespace/openshift-console route/console stopped responding to GET requests over new connections: Get "https://console-openshift-console.apps.ci-op-08lhviwy-8964d.origin-ci-int-aws.dev.rhcloud.com/healthz": EOF}

retesting this for now, but will double check versus next run

@tssurya
Copy link
Contributor Author

tssurya commented Feb 8, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@tssurya: This pull request references Jira Issue OCPBUGS-28819, which is invalid:

  • expected dependent Jira Issue OCPBUGS-28818 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead
  • expected dependent Jira Issue OCPBUGS-28818 to target a version in 4.15.0, but it targets "4.15.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tssurya
Support permanent session affinity
5daa77d 
OVN drops the first packet from a given client
for every new session which is undesirable and
a regression compared to how SDN behaves (it can
be argued that this is an implementation detail
but ultimately users want same behaviour and no
drops). This is a complicated fix and will take
time.
The OVN fix will take time and in K8s there is no
affinity without a timeout unfortunately. So in
OVNKube we will introduce permanent session affinity
as an alternative. Hence if user sets 86000 which is
the highest timeout value it would mean no timeout.
This is not how the K8s definition works, this will be
an ovnkube implementation detail.
There is no harm in changing what a 1 day timeout means
from it being a day to it being infinite affinity because
either ways OVN only supports upto 18hours of timeout value
max (UINT_MAX). So currently range 18-24 is not used and
is configured as 18 itself in OVN.
So from this change forward, if timeout is set to 86000
by the user, they will get permanent session affinity.

Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
(cherry picked from commit 88a5140)
(cherry picked from commit 85e3fdf)
@tssurya
Vendor in the files from k8s
4d92442 
Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
(cherry picked from commit 28984e5)
(cherry picked from commit 1759d33)
@tssurya
Add UTs for session affinity config's
a273640 
Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
(cherry picked from commit de0cd0e)
(cherry picked from commit 86a0457)
@tssurya
Run go mod vendor && go mod tidy
3e6cc2a 
Since we are cherry-picking packaged library rerunning
go mod vendor and tidy on latest

Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
@tssurya
Copy link
Contributor Author

tssurya commented Feb 8, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@tssurya: This pull request references Jira Issue OCPBUGS-28819, which is invalid:

  • expected dependent Jira Issue OCPBUGS-28818 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tssurya
Copy link
Contributor Author

tssurya commented Feb 8, 2024

/retest-required

@tssurya
Copy link
Contributor Author

tssurya commented Feb 8, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@tssurya: This pull request references Jira Issue OCPBUGS-28819, which is invalid:

  • expected dependent Jira Issue OCPBUGS-28818 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tssurya
Copy link
Contributor Author

tssurya commented Feb 9, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@tssurya: This pull request references Jira Issue OCPBUGS-28819, which is invalid:

  • expected dependent Jira Issue OCPBUGS-28818 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@asood-rh
Copy link

@tssurya The PR needs backport assessed label.
The PR has been pre merge tested. Details in the bug.

/label cherry-pick-approved
/label qe-approved

@openshift-ci openshift-ci bot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. qe-approved Signifies that QE has signed off on this PR labels Feb 12, 2024
@trozet
Copy link
Contributor

trozet commented Feb 13, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: trozet, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tssurya
Copy link
Contributor Author

tssurya commented Feb 14, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@tssurya: This pull request references Jira Issue OCPBUGS-28819, which is invalid:

  • expected dependent Jira Issue OCPBUGS-28818 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tssurya
Copy link
Contributor Author

tssurya commented Feb 14, 2024

/retest-required

@tssurya
Copy link
Contributor Author

tssurya commented Feb 14, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 14, 2024
@openshift-ci-robot
Copy link
Contributor

@tssurya: This pull request references Jira Issue OCPBUGS-28819, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-28818 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-28818 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jechen@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tssurya
Copy link
Contributor Author

tssurya commented Feb 14, 2024

/test 4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade

@trozet
Copy link
Contributor

trozet commented Feb 14, 2024

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 14, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 87016e7 and 2 for PR HEAD 3e6cc2a in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 15, 2024 •
edited

@tssurya: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 3e6cc2a link false /test security
ci/prow/e2e-openstack-ovn 3e6cc2a link false /test e2e-openstack-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tssurya
Copy link
Contributor Author

tssurya commented Feb 15, 2024

/test e2e-metal-ipi-ovn-dualstack

@openshift-merge-bot openshift-merge-bot bot merged commit 4d6dd53 into openshift:release-4.14 Feb 15, 2024
26 of 28 checks passed
@openshift-ci-robot
Copy link
Contributor

@tssurya: Jira Issue OCPBUGS-28819: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-28819 has been moved to the MODIFIED state.

In response to this:

CLEAN Cherry-pick of #2045

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-ovn-kubernetes-base-container-v4.14.0-202402151739.p0.g4d6dd53.assembly.stream.el9 for distgit ovn-kubernetes-base.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.14.0-0.nightly-2024-02-16-015828

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcbw dcbw Awaiting requested review from dcbw

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

@jcaamano jcaamano Awaiting requested review from jcaamano

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@trozet trozet

@weliang1 weliang1

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@yingwang-0320 yingwang-0320

@qiowang721 qiowang721

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet