[release-4.15] OCPBUGS-29001: kubevirt, Replace routes on migration

[qinqon]

- What this PR does and why is it needed
Kubevirt live migration between nodes that do not own the VM subnet are creating wrongly at ECMP route since is not replacing the point to point routes, this breaks traffic.

This change use just just IPPrefix and Policy at the point to point routes predicate to prevent ECMP.

(cherry picked from commit fb4dec8)

Closes https://issues.redhat.com/browse/OCPBUGS-29001

[openshift-ci-robot]

@qinqon: This pull request references Jira Issue OCPBUGS-29001, which is invalid:

• expected Jira Issue OCPBUGS-29001 to depend on a bug targeting a version in 4.16.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

- What this PR does and why is it needed
Kubevirt live migration between nodes that do not own the VM subnet are creating wrongly at ECMP route since is not replacing the point to point routes, this breaks traffic.

This change use just just IPPrefix and Policy at the point to point routes predicate to prevent ECMP.

Signed-off-by: Enrique Llorente ellorent@redhat.com
(cherry picked from commit fb4dec8)

Closes https://issues.redhat.com/browse/OCPBUGS-29001

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[qinqon]

/jira refresh

[openshift-ci-robot]

@qinqon: This pull request references Jira Issue OCPBUGS-29001, which is invalid:

• expected Jira Issue OCPBUGS-29001 to depend on a bug targeting a version in 4.16.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[qinqon]

/jira refresh

[openshift-ci-robot]

@qinqon: This pull request references Jira Issue OCPBUGS-29001, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.0) matches configured target version for branch (4.15.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-27215 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
• dependent Jira Issue OCPBUGS-27215 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jechen@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[qinqon]

/cherry-pick release-4.14

[openshift-cherrypick-robot]

@qinqon: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[maiqueb]

hm, CI fails pretty bad ...

Are we sure this PR is OK ?

[qinqon]

/retest

[qinqon]

/retest-required

[qinqon]

/test e2e-aws-ovn-kubevirt

[maiqueb]

Thank you.

[openshift-ci]

@qinqon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	5738f0a	link	false	/test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[tssurya]

/lgtm
label backport-risk-assessed
exactly same clean pick of 7f99281

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maiqueb, qinqon, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tssurya]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tssurya]

/label backport-risk-assessed

[qiowang721]

/label cherry-pick-approved

[openshift-ci-robot]

@qinqon: Jira Issue OCPBUGS-29001: All pull requests linked via external trackers have merged:

• openshift/ovn-kubernetes#2052

Jira Issue OCPBUGS-29001 has been moved to the MODIFIED state.

In response to this:

- What this PR does and why is it needed
Kubevirt live migration between nodes that do not own the VM subnet are creating wrongly at ECMP route since is not replacing the point to point routes, this breaks traffic.

This change use just just IPPrefix and Policy at the point to point routes predicate to prevent ECMP.

(cherry picked from commit fb4dec8)

Closes https://issues.redhat.com/browse/OCPBUGS-29001

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-cherrypick-robot]

@qinqon: #2052 failed to apply on top of branch "release-4.14":

Applying: kubevirt: Replace routes on migration
Using index info to reconstruct a base tree...
M	.github/workflows/test.yml
M	go-controller/pkg/kubevirt/router.go
M	go-controller/pkg/ovn/kubevirt_test.go
M	test/e2e/kubevirt.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/kubevirt.go
CONFLICT (content): Merge conflict in test/e2e/kubevirt.go
Auto-merging go-controller/pkg/ovn/kubevirt_test.go
Auto-merging go-controller/pkg/kubevirt/router.go
Auto-merging .github/workflows/test.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 kubevirt: Replace routes on migration
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-ovn-kubernetes-base-container-v4.15.0-202402061338.p0.g6a4ea84.assembly.stream.el9 for distgit ovn-kubernetes-base.
All builds following this will include this PR.

[openshift-merge-robot]

Fix included in accepted release 4.15.0-0.nightly-2024-02-06-174950