OCPBUGS-33421: [release-4.13] Full implementation of KEP-1669 ProxyTerminatingEndpoints + ETP=local fix #2130
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
/payload nightly |
|
@ricky-rav: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info. |
|
/test unit |
ricky-rav
changed the title
ricky-rav
force-pushed
the
kep-1669-bis_413
branch
from
d399e48
to
d2dbf0c
Compare
|
/retest |
ricky-rav
force-pushed
the
kep-1669-bis_413
branch
4 times, most recently
from
cc29fe7
to
161d5a8
Compare
|
/retest |
ricky-rav
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
ricky-rav
force-pushed
the
kep-1669-bis_413
branch
from
161d5a8
to
151a5f5
Compare
ricky-rav
force-pushed
the
kep-1669-bis_413
branch
from
151a5f5
to
171290b
Compare
|
/jira cherrypick OCPBUGS-32319 |
|
@jcaamano: Jira Issue OCPBUGS-32319 has been cloned as Jira Issue OCPBUGS-33421. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/severity-important
|
@ricky-rav: This pull request references Jira Issue OCPBUGS-33421, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
/payload 4.13 ci blocking |
|
@jcaamano: trigger 4 job(s) of type blocking for the ci release of OCP 4.13
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9adf8040-0d53-11ef-85bf-86d25e0538e5-0 trigger 6 job(s) of type blocking for the nightly release of OCP 4.13
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9adf8040-0d53-11ef-85bf-86d25e0538e5-1 |
| @@ -752,7 +752,7 @@ func (nc *DefaultNodeNetworkController) reconcileConntrackUponEndpointSliceEvent | |||
| // nothing to do upon an add event | |||
| return nil | |||
| } | |||
| namespacedName, err := serviceNamespacedNameFromEndpointSlice(oldEndpointSlice) | |||
| namespacedName, err := util.ServiceNamespacedNameFromEndpointSlice(oldEndpointSlice) | |||
There was a problem hiding this comment.
Wondering if we should get rid of serviceNamespacedNameFromEndpointSlice
which is what originally happened in
8c7ea95
I would be more concerned if we actually need any of those changes rather than being concerned about this cosmetic issue.
Are we actually cherry picking some but not all of those changes? Perhaps it is cleaner to just cherry-pick that as well.
There was a problem hiding this comment.
Can you edit the opening message with the conflicts that you got after using these two cherry-picks? Thanks!
There was a problem hiding this comment.
Done! I'll do the same for 4.12 tomorrow. Thanks!
| @@ -575,6 +575,7 @@ func serviceUpdateNotNeeded(old, new *kapi.Service) bool { | |||
|
|
|||
| // AddService handles configuring shared gateway bridge flows to steer External IP, Node Port, Ingress LB traffic into OVN | |||
| func (npw *nodePortWatcher) AddService(service *kapi.Service) error { | |||
| var localEndpoints sets.Set[string] | |||
There was a problem hiding this comment.
OK I think I am actually confused, because you say same changes but there are differences here.
There was a problem hiding this comment.
True. There are some differences in the code, but it didn't lead to any conflicts.
|
/payload 4.13 ci blocking |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcaamano, ricky-rav The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jcaamano: trigger 4 job(s) of type blocking for the ci release of OCP 4.13
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/280d8990-11ea-11ef-9eee-14cebc9d9b83-0 trigger 6 job(s) of type blocking for the nightly release of OCP 4.13
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/280d8990-11ea-11ef-9eee-14cebc9d9b83-1 |
openshift-ci
bot
added
the
approved
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
/jira refresh |
|
@ricky-rav: This pull request references Jira Issue OCPBUGS-33421, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@ricky-rav: This pull request references Jira Issue OCPBUGS-33421, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jechen@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload-job periodic-ci-openshift-release-master-ci-4.13-e2e-azure-ovn-upgrade |
|
@jcaamano: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a04e0cd0-1209-11ef-8983-816505d1df85-0 |
|
pre-merge tested 2nd around with latest update |
|
/ocpbugs cc-qa |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
@ricky-rav: This pull request references Jira Issue OCPBUGS-33421, which is valid. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jechen@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
openshift-merge-bot
bot
merged commit 221f418
into
openshift:release-4.13
|
@ricky-rav: Jira Issue OCPBUGS-33421: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-33421 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-ovn-kubernetes-base-container-v4.13.0-202405151107.p0.g221f418.assembly.stream.el9 for distgit ovn-kubernetes-base. |
Differences from 4.14 backport (#2128):
I had to backport two relevant commits from last year that hadn't been backported to 4.13.
[commit 1] Consider serving endpoints in hasLocalHostNetworkEndpoints 8f0bfab
[commit 2] Cleanup of endpoint handling functions 8c7ea95
[commit 3] Full implementation of KEP-1669 ProxyTerminatingEndpoints
[commit 4] Fix endpoint selection for externalTrafficPolicy=local
lb_config_test.go:
go-controller/pkg/node/healthcheck_service.go
go-controller/pkg/node/gateway_localnet_linux_test.go
go-controller/pkg/node/healthcheck_service.go
go-controller/pkg/ovn/controller/services/lb_config.go
go-controller/pkg/ovn/controller/services/load_balancer_ocphack_test.go**
go-controller/pkg/util/kube.go
go-controller/pkg/ovn/controller/services/node_tracker.go**
go-controller/pkg/ovn/controller/services/services_controller.go
buildTemplateLBson one line instead of being split into two