OCPBUGS-33020: drop-forwarding: Add ClusterSubnets to allowed forwarding CIDRs

[arghosh93]

Clean cherry pick from #2018
Commit f062cbb introduced a default FORWARD DROP for breth0 and allow-listed Service CIDRs and the masquerade IPs. However, this breaks Egress Service traffic. Add the ClusterCIDRs to the allow-list.

Reported-at: ovn-org/ovn-kubernetes#4042

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

[openshift-ci-robot]

@arghosh93: Jira Issue OCPBUGS-31729 is in a security level that is not in the allowed security levels for this repo.
Allowed security levels for this repo are:

• Red Hat Employee
• default

In response to this:

Clean cherry pick from #2018
Commit f062cbb introduced a default FORWARD DROP for breth0 and allow-listed Service CIDRs and the masquerade IPs. However, this breaks Egress Service traffic. Add the ClusterCIDRs to the allow-list.

Reported-at: ovn-org/ovn-kubernetes#4042

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hi @arghosh93. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@arghosh93: This pull request references Jira Issue OCPBUGS-33020, which is invalid:

• expected the bug to target the "4.15.z" version, but no target version was set
• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
• expected Jira Issue OCPBUGS-33020 to depend on a bug targeting a version in 4.16.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Clean cherry pick from #2018
Commit f062cbb introduced a default FORWARD DROP for breth0 and allow-listed Service CIDRs and the masquerade IPs. However, this breaks Egress Service traffic. Add the ClusterCIDRs to the allow-list.

Reported-at: ovn-org/ovn-kubernetes#4042

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[arghosh93]

/jira refresh

[openshift-ci-robot]

@arghosh93: This pull request references Jira Issue OCPBUGS-33020, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.z) matches configured target version for branch (4.15.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-25637 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-25637 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
• bug has dependents

Requesting review from QA contact:
/cc @huiran0826

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jcaamano]

/lgtm
/approve
/label backport-risk-assessed
/ok-to-test

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arghosh93, jcaamano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jcaamano]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jcaamano]

@arghosh93 FYI cherry-pick -x adds a reference in the commit message to the cherry-picked commit that is easier to track.

[asood-rh]

/label cherry-pick-approved

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD feca446 and 2 for PR HEAD e071df4 in total

[arghosh93]

@arghosh93 FYI cherry-pick -x adds a reference in the commit message to the cherry-picked commit that is easier to track.

Noted @jcaamano , Thanks so much!

[arghosh93]

/retest-required

[arghosh93]

/retest-required

[openshift-ci]

@arghosh93: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-live-migration-sdn-ovn-rollback	e071df4	link	false	/test e2e-aws-live-migration-sdn-ovn-rollback
ci/prow/e2e-ovn-hybrid-step-registry	e071df4	link	false	/test e2e-ovn-hybrid-step-registry
ci/prow/e2e-vsphere-ovn	e071df4	link	false	/test e2e-vsphere-ovn
ci/prow/security	e071df4	link	false	/test security
ci/prow/e2e-aws-ovn-kubevirt	e071df4	link	false	/test e2e-aws-ovn-kubevirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[huiran0826]

/label qe-approved

[openshift-ci-robot]

@arghosh93: This pull request references Jira Issue OCPBUGS-33020, which is valid.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.z) matches configured target version for branch (4.15.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-25637 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-25637 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
• bug has dependents

Requesting review from QA contact:
/cc @huiran0826

In response to this:

Clean cherry pick from #2018
Commit f062cbb introduced a default FORWARD DROP for breth0 and allow-listed Service CIDRs and the masquerade IPs. However, this breaks Egress Service traffic. Add the ClusterCIDRs to the allow-list.

Reported-at: ovn-org/ovn-kubernetes#4042

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[arghosh93]

/retest-required

[openshift-ci-robot]

@arghosh93: Jira Issue OCPBUGS-33020: All pull requests linked via external trackers have merged:

• openshift/ovn-kubernetes#2141

Jira Issue OCPBUGS-33020 has been moved to the MODIFIED state.

In response to this:

Clean cherry pick from #2018
Commit f062cbb introduced a default FORWARD DROP for breth0 and allow-listed Service CIDRs and the masquerade IPs. However, this breaks Egress Service traffic. Add the ClusterCIDRs to the allow-list.

Reported-at: ovn-org/ovn-kubernetes#4042

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ovn-kubernetes-microshift-container-v4.15.0-202404291137.p0.gcfd52d8.assembly.stream.el9 for distgit ovn-kubernetes-microshift.
All builds following this will include this PR.

[openshift-merge-robot]

Fix included in accepted release 4.15.0-0.nightly-2024-04-29-230005