Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-33328,OCPBUGS-30224,SDN-4388,OCPBUGS-32161: [DownstreamMerge] 10 may 2024 #2162

Merged
merged 36 commits into from
May 13, 2024

Conversation

npinaeva
Copy link
Member

no conflicts

girishmg and others added 30 commits May 4, 2024 13:43
Signed-off-by: Girish Moodalbail <gmoodalbail@nvidia.com>
Signed-off-by: Girish Moodalbail <gmoodalbail@nvidia.com>
Signed-off-by: Girish Moodalbail <gmoodalbail@nvidia.com>
Signed-off-by: Girish Moodalbail <gmoodalbail@nvidia.com>
Signed-off-by: Girish Moodalbail <gmoodalbail@nvidia.com>
Signed-off-by: Girish Moodalbail <gmoodalbail@nvidia.com>
add a CSS option to align all the images inserted using markdown in
center

Signed-off-by: Girish Moodalbail <gmoodalbail@nvidia.com>
the ovnkube-node daemon running wiht hostPID set to false will not
share the process namespace with the host, and therefore will not be
able to collect any ovs-vswitchd or ovsdb-server related processes.

Signed-off-by: Girish Moodalbail <gmoodalbail@nvidia.com>
errors.As() is not supported[1] with Aggregate type error. This PR
is to unfurl Aggregate type error into a slice of builtin error by
using Aggregate.Errors() function. errors.As() can then be used
with each element of the slice.

This PR also wraps 'annotation not found' errors for remote zone
nodes with SuppressedError type to suppress expected logs for remote
zone nodes going forward.

Upstream Issue: ovn-org/ovn-kubernetes#4332
[1] - https://pkg.go.dev/k8s.io/apimachinery/pkg/util/errors#Aggregate

Signed-off-by: Arnab Ghosh <arnabghosh89@gmail.com>
the API reference documentation was generated by using this project
https://github.com/elastic/crd-ref-docs/. The config that was used to
generate the API is

$ go install github.com/elastic/crd-ref-docs@latest
$ ~/gowork/bin/crd-ref-docs \
  --source-path=~/gowork/src/githubcom/ovn-org/ovn-kubernetes/\
  go-controller/pkg/crd/egressfirewall/ \
  --config=crd-docs-config.yaml --renderer=markdown \
  --output-path=./docs/developer-guide/egress-firewall-api-spec.md

Signed-off-by: Girish Moodalbail <gmoodalbail@nvidia.com>
Signed-off-by: Girish Moodalbail <gmoodalbail@nvidia.com>
Signed-off-by: Girish Moodalbail <gmoodalbail@nvidia.com>
Signed-off-by: Girish Moodalbail <gmoodalbail@nvidia.com>
Signed-off-by: Girish Moodalbail <gmoodalbail@nvidia.com>
Signed-off-by: Girish Moodalbail <gmoodalbail@nvidia.com>
OVS Process metrics cannot be collected through the PID file location
Signed-off-by: arkadeepsen <arsen@redhat.com>
…upport wildcard DNS name

Signed-off-by: arkadeepsen <arsen@redhat.com>
Signed-off-by: arkadeepsen <arsen@redhat.com>
Signed-off-by: arkadeepsen <arsen@redhat.com>
Signed-off-by: arkadeepsen <arsen@redhat.com>
… add/delete node event

Currently, allocated_v4_host_subnet & allocated_v6_host_subnet metrics are not being updated
during add/delete node event.

Signed-off-by: Pardhakeswar Pacha <ppacha@nvidia.com>
OVNKubeAllocatedSubnetsDoNotMatch alert gets triggered when
ovnkube_clustermanager_allocated_v4_host_subnets and
ovnkube_clustermanager_allocated_v6_host_subnets metrics doesn't match
the number of k8s nodes in cluster

Signed-off-by: Pardhakeswar Pacha <ppacha@nvidia.com>
Add logic to unfurl Aggregate type error in IsSuppressedError function
document on how we do web designing for ovn-kubernetes project
Signed-off-by: Patryk Diak <pdiak@redhat.com>
Signed-off-by: Patryk Diak <pdiak@redhat.com>
Update ovnkube_clustermanager_allocated_v4_host_subnets metric during add/delete node event
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 10, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 10, 2024

@npinaeva: This pull request references Jira Issue OCPBUGS-33328, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-30224, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references SDN-4388 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

no conflicts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@martinkennelly
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 10, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 10, 2024

@martinkennelly: This pull request references Jira Issue OCPBUGS-33328, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

This pull request references Jira Issue OCPBUGS-30224, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

This pull request references SDN-4388 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@martinkennelly
Copy link
Contributor

/test e2e-metal-ipi-ovn-ipv6

@martinkennelly
Copy link
Contributor

/test okd-images

@martinkennelly
Copy link
Contributor

/test 4.16-upgrade-from-stable-4.15-local-gateway-e2e-aws-ovn-upgrade

Unrelated

@martinkennelly
Copy link
Contributor

/test e2e-azure-ovn-upgrade

Unrelated

@martinkennelly
Copy link
Contributor

/test e2e-openstack-ovn

5 LB tests failed - not sure why. Retesting.
Tests:

[sig-installer][Suite:openshift/openstack][lb][Serial] The Openstack platform should create a UDP Amphora LoadBalancer when a UDP svc with type:LoadBalancer is created on Openshift 
[sig-installer][Suite:openshift/openstack][lb][Serial] The Openstack platform should create a TCP Amphora LoadBalancer when LoadBalancerService ingressController is created on Openshift 
[sig-installer][Suite:openshift/openstack][lb][Serial] The Openstack platform should limit service access on an UDP Amphora LoadBalancer when an UDP LoadBalancer svc setting the loadBalancerSourceRanges spec is created on Openshift 
[sig-installer][Suite:openshift/openstack][lb][Serial] The Openstack platform should apply lb-method on UDP Amphora LoadBalancer when a UDP svc with monitors and ETP:Local is created on Openshift
[sig-installer][Suite:openshift/openstack][lb][Serial] The Openstack platform should create a TCP Amphora LoadBalancer when a TCP svc with type:LoadBalancer is created on Openshift 

@martinkennelly
Copy link
Contributor

/test okd-e2e-gcp-ovn
API server didnt come up:

dial tcp 34.135.229.205:6443: connect: connection refused

Copy link
Contributor

openshift-ci bot commented May 13, 2024

@npinaeva: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security c05197c link false /test security
ci/prow/okd-e2e-gcp-ovn c05197c link false /test okd-e2e-gcp-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jcaamano
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2024
Copy link
Contributor

openshift-ci bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaamano, npinaeva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 0dce120 into openshift:master May 13, 2024
31 of 33 checks passed
@openshift-ci-robot
Copy link
Contributor

@npinaeva: Jira Issue OCPBUGS-33328: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33328 has been moved to the MODIFIED state.

Jira Issue OCPBUGS-30224: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30224 has been moved to the MODIFIED state.

In response to this:

no conflicts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@npinaeva npinaeva deleted the merge-10-may-2024 branch May 13, 2024 14:32
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-ovn-kubernetes-base-container-v4.17.0-202405132002.p0.g0dce120.assembly.stream.el9 for distgit ovn-kubernetes-base.
All builds following this will include this PR.

@npinaeva
Copy link
Member Author

/payload 4.16 ci blocking
/payload 4.16 nightly blocking

Copy link
Contributor

openshift-ci bot commented May 14, 2024

@npinaeva: trigger 5 job(s) of type blocking for the ci release of OCP 4.16

  • periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-azure-sdn-upgrade
  • periodic-ci-openshift-release-master-ci-4.16-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.16-e2e-aws-sdn-serial
  • periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e14479a0-11c7-11ef-9f73-2f424dd4a160-0

trigger 8 job(s) of type blocking for the nightly release of OCP 4.16

  • periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-sdn-upgrade
  • periodic-ci-openshift-release-master-ci-4.16-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.16-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e14479a0-11c7-11ef-9f73-2f424dd4a160-1

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-05-14-095225

@jcaamano
Copy link
Contributor

jcaamano commented May 20, 2024

/retitle OCPBUGS-33328,OCPBUGS-30224,SDN-4388,OCPBUGS-32161: [DownstreamMerge] 10 may 2024

@openshift-ci openshift-ci bot changed the title OCPBUGS-33328,OCPBUGS-30224,SDN-4388: [DownstreamMerge] 10 may 2024 OCPBUGS-33328,OCPBUGS-30224,SDN-4388,OCPBUGS-32161: [DownstreamMerge] 10 may 2024 May 20, 2024
@openshift-ci-robot
Copy link
Contributor

@npinaeva: Jira Issue OCPBUGS-33328 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

Jira Issue OCPBUGS-30224 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

Jira Issue OCPBUGS-32161 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

In response to this:

no conflicts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet