Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1874928: Pinning the OVN version for 4.5.8 release #248

Conversation

alexanderConstantinescu
Copy link
Contributor

Pin the version for 4.5.8 as to avoid problems during the upgrade from 4.5.7 -> 4.5.8

/assign @knobunc @joepvd

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

@openshift-ci-robot
Copy link
Contributor

@alexanderConstantinescu: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Pinning the OVN version for 4.5.8 release

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Contributor

dcbw commented Sep 2, 2020

As long as there's a Jira card and commitment to revert this PR after 4.5.7 ships, ok with me.

@alexanderConstantinescu
Copy link
Contributor Author

alexanderConstantinescu commented Sep 2, 2020

As long as there's a Jira card and commitment to revert this PR after 4.5.7 ships, ok with me.

There is for the commitment to revert. Once openshift/cluster-network-operator#755 merges and has been back-ported, we'll be able to revert this.

@knobunc
Copy link
Contributor

knobunc commented Sep 2, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 2, 2020
@knobunc
Copy link
Contributor

knobunc commented Sep 2, 2020

@dcbw we are tracking it with the urgent bug https://bugzilla.redhat.com/show_bug.cgi?id=1874737 for a 4.5 revert.

@knobunc
Copy link
Contributor

knobunc commented Sep 2, 2020

/retest

@joepvd
Copy link
Contributor

joepvd commented Sep 2, 2020

From build:

Installing:
 ovn2.13            x86_64    2.13.0-39.el7fdp      rhel-fast-datapath    4.2 M
 ovn2.13-central    x86_64    20.06.1-6.el7fdp      rhel-fast-datapath  1.8M
 ovn2.13-host       x86_64    20.06.1-6.el7fdp      rhel-fast-datapath   980k
 ovn2.13-vtep       x86_64    20.06.1-6.el7fdp      rhel-fast-datapath   862k

Version pin worked, but might need to be supplied to all packages.

Signed-off-by: Alexander Constantinescu <aconstan@redhat.com>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2020
@knobunc knobunc changed the title Pinning the OVN version for 4.5.8 release Bug 1874928: Pinning the OVN version for 4.5.8 release Sep 2, 2020
@openshift-ci-robot
Copy link
Contributor

@alexanderConstantinescu: This pull request references Bugzilla bug 1874928, which is invalid:

  • expected dependent Bugzilla bug 1874385 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1874928: Pinning the OVN version for 4.5.8 release

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 2, 2020
@knobunc
Copy link
Contributor

knobunc commented Sep 2, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@knobunc: This pull request references Bugzilla bug 1874928, which is invalid:

  • expected dependent Bugzilla bug 1874385 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knobunc knobunc added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 2, 2020
@knobunc
Copy link
Contributor

knobunc commented Sep 2, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderConstantinescu, knobunc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knobunc
Copy link
Contributor

knobunc commented Sep 2, 2020

Why I overrode: There is no 4.6 change for this since we do not want to change the ovn version there. The override was needed so that we could pin the ovn version in 4.5 so that we don't have a schema upgrade yet. We have a 4.6 PR to support schema upgrades properly (openshift/cluster-network-operator#755) with 4.6 and 4.5 tracking bugs. Once that PR lands and is backported to 4.5 we will revert this change.

@alexanderConstantinescu
Copy link
Contributor Author

Seems to be properly pinned now:

Installed:
  ovn2.13.x86_64 0:2.13.0-39.el7fdp                                             
  ovn2.13-central.x86_64 0:2.13.0-39.el7fdp                                     
  ovn2.13-host.x86_64 0:2.13.0-39.el7fdp                                        
  ovn2.13-vtep.x86_64 0:2.13.0-39.el7fdp    

From: https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_ovn-kubernetes/248/pull-ci-openshift-ovn-kubernetes-release-4.5-images/1301177262988595200/artifacts/build-logs/ovn-kubernetes.log

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@crawford crawford added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 2, 2020
@knobunc
Copy link
Contributor

knobunc commented Sep 2, 2020

/override ci/prow/e2e-gcp-ovn-upgrade

We have test runs of gcp-ovn that passed on clusterbot, and the failures we had have been flakes in the past.

@knobunc
Copy link
Contributor

knobunc commented Sep 2, 2020

/override ci/prow/e2e-gcp-ovn-upgrade

@openshift-ci-robot
Copy link
Contributor

@knobunc: Overrode contexts on behalf of knobunc: ci/prow/e2e-gcp-ovn-upgrade

In response to this:

/override ci/prow/e2e-gcp-ovn-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit cee91f2 into openshift:release-4.5 Sep 2, 2020
@openshift-ci-robot
Copy link
Contributor

@alexanderConstantinescu: All pull requests linked via external trackers have merged:

Bugzilla bug 1874928 has been moved to the MODIFIED state.

In response to this:

Bug 1874928: Pinning the OVN version for 4.5.8 release

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants