Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1882694: Pin OVS to latest 4.4.22 RPM version #290

Merged
merged 1 commit into from Jan 28, 2021
Merged

Bug 1882694: Pin OVS to latest 4.4.22 RPM version #290

merged 1 commit into from Jan 28, 2021

Conversation

alexanderConstantinescu
Copy link
Contributor

As done in #284 but for OVS

/assign @dcbw @trozet

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Sep 25, 2020
@openshift-ci-robot
Copy link
Contributor

@alexanderConstantinescu: This pull request references Bugzilla bug 1882694, which is invalid:

  • expected the bug to target the "4.5.z" release, but it targets "---" instead
  • expected dependent Bugzilla bug 1882707 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead
  • expected dependent Bugzilla bug 1882707 to target a release in 4.6.0, 4.6.z, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1882694: Pin OVS to latest 4.4.22 RPM version

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 25, 2020
@alexanderConstantinescu
Copy link
Contributor Author

/retitle Bug 1882694: [release-4.5] Pin OVS to latest 4.4.22 RPM version

@openshift-ci-robot openshift-ci-robot changed the title Bug 1882694: Pin OVS to latest 4.4.22 RPM version Bug 1882694: [release-4.5] Pin OVS to latest 4.4.22 RPM version Sep 25, 2020
trozet
trozet suggested changes Sep 25, 2020
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@alexanderConstantinescu
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@alexanderConstantinescu: This pull request references Bugzilla bug 1882694, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1882707 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1882707 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 28, 2020
@dcbw
Copy link
Contributor

dcbw commented Oct 14, 2020

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 14, 2020 •
edited

@alexanderConstantinescu: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-metal-ipi a9c0f12 link /test e2e-metal-ipi
ci/prow/e2e-metal-ipi-ovn-ipv6 a9c0f12 link /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@alexanderConstantinescu
Copy link
Contributor Author

/retest

How about an /lgtm and /approve and we let the bot do that for us? 😈

@trozet
Copy link
Contributor

trozet commented Nov 19, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2020
@knobunc
Copy link
Contributor

knobunc commented Dec 1, 2020

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2020
@knobunc
Copy link
Contributor

knobunc commented Dec 1, 2020

/cherrypick 4.4.z

@alexanderConstantinescu
Copy link
Contributor Author

alexanderConstantinescu commented Dec 1, 2020 •
edited

/hold

this PR has been on the back-burner for too long. OVS on 4.4.z and 4.5.z have been bumped to 2.13.0-50.el7fdp. And moreover, I this PR needs to bump OVS to 2.13.0-62.el7fdp as to get the CVE fix in directly. But first we will need #358 to get in and have master and 4.6 on that version

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2020
@crawford crawford changed the title Bug 1882694: [release-4.5] Pin OVS to latest 4.4.22 RPM version Bug 1882694: Pin OVS to latest 4.4.22 RPM version Jan 21, 2021
@crawford
Copy link

@alexanderConstantinescu any update?

@alexanderConstantinescu
Bug 1882694: Pin OVS to latest 4.4.22 RPM version
90aa77a 
Signed-off-by: Alexander Constantinescu <aconstan@redhat.com>
@alexanderConstantinescu
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jan 26, 2021
@trozet
Copy link
Contributor

trozet commented Jan 26, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderConstantinescu, knobunc, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jwforres jwforres added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 27, 2021
@openshift-merge-robot openshift-merge-robot merged commit 151192c into openshift:release-4.5 Jan 28, 2021
@openshift-ci-robot
Copy link
Contributor

@alexanderConstantinescu: All pull requests linked via external trackers have merged:

Bugzilla bug 1882694 has been moved to the MODIFIED state.

In response to this:

Bug 1882694: Pin OVS to latest 4.4.22 RPM version

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@knobunc: cannot checkout 4.4.z: error checking out 4.4.z: exit status 1. output: error: pathspec '4.4.z' did not match any file(s) known to git

In response to this:

/cherrypick 4.4.z

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trozet trozet trozet requested changes

@rcarrillocruz rcarrillocruz Awaiting requested review from rcarrillocruz

@squeed squeed Awaiting requested review from squeed

Assignees

@trozet trozet

@dcbw dcbw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@alexanderConstantinescu @openshift-ci-robot @dcbw @trozet @knobunc @crawford @openshift-bot @openshift-cherrypick-robot @jwforres @openshift-merge-robot