New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing python3-pyOpenSSL library #323
Add missing python3-pyOpenSSL library #323
Conversation
35edc6b
to
3fa9bad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume the image already contains python? If not, I don't think we want to be adding all of that just for a debugging tool...
This commit adds python3-pyOpenSSL to the Dockerfile, needed for ovn-detrace to work with ssl endpoints. Signed-off-by: Daniel Mellado <dmellado@redhat.com>
3fa9bad
to
7c77966
Compare
@danwinship yeah, i think the images do include python already. These are the only aditional dependencies that this PR adds due to python3-openssl:
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielmellado, dcbw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
@danielmellado: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/override ci/prow/e2e-aws-ovn Continuing capacity issues, and this PR only changes image build which clearly worked. |
@dcbw: Overrode contexts on behalf of dcbw: ci/prow/e2e-aws-ovn, ci/prow/e2e-gcp-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR adds python3-pyOpenSSL to the Dockerfile, needed for ovn-detrace to
work with ssl endpoints.