Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing python3-pyOpenSSL library #323

Merged
merged 1 commit into from Dec 2, 2020

Conversation

danielmellado
Copy link
Contributor

This PR adds python3-pyOpenSSL to the Dockerfile, needed for ovn-detrace to
work with ssl endpoints.

Copy link
Contributor

@danwinship danwinship left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the image already contains python? If not, I don't think we want to be adding all of that just for a debugging tool...

Dockerfile Outdated Show resolved Hide resolved
This commit adds python3-pyOpenSSL to the Dockerfile, needed for ovn-detrace
to work with ssl endpoints.

Signed-off-by: Daniel Mellado <dmellado@redhat.com>
@dcbw
Copy link
Contributor

dcbw commented Nov 30, 2020

I assume the image already contains python? If not, I don't think we want to be adding all of that just for a debugging tool...

@danwinship yeah, i think the images do include python already. These are the only aditional dependencies that this PR adds due to python3-openssl:

Installing dependencies:
 python3-asn1crypto            noarch  0.24.0-3.el8                         rhel-8-baseos     181 k
 python3-cffi                  x86_64  1.11.5-5.el8                         rhel-8-baseos     238 k
 python3-cryptography          x86_64  2.3-3.el8                            rhel-8-baseos     511 k
 python3-idna                  noarch  2.5-5.el8                            rhel-8-baseos      97 k
 python3-pycparser             noarch  2.14-14.el8                          rhel-8-baseos     109 k

@dcbw
Copy link
Contributor

dcbw commented Nov 30, 2020

/lgtm
/approve
/retest

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielmellado, dcbw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 30, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Dec 1, 2020

@danielmellado: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-ovn-hybrid-step-registry 7c77966 link /test e2e-ovn-hybrid-step-registry
ci/prow/e2e-openstack-ovn 7c77966 link /test e2e-openstack-ovn
ci/prow/e2e-azure-ovn 7c77966 link /test e2e-azure-ovn
ci/prow/e2e-vsphere-ovn 7c77966 link /test e2e-vsphere-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dcbw
Copy link
Contributor

dcbw commented Dec 2, 2020

/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-gcp-ovn

Continuing capacity issues, and this PR only changes image build which clearly worked.

@openshift-ci-robot
Copy link
Contributor

@dcbw: Overrode contexts on behalf of dcbw: ci/prow/e2e-aws-ovn, ci/prow/e2e-gcp-ovn

In response to this:

/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-gcp-ovn

Continuing capacity issues, and this PR only changes image build which clearly worked.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw dcbw merged commit e887c6f into openshift:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants