Fix hardcoded namespace in ovnkube.sh #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
pecameron
reviewed
Apr 23, 2019
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, pecameron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
dcbw
reviewed
Apr 25, 2019
| @@ -149,7 +149,7 @@ wait_for_event () { | |||
| ready_to_start_node () { | |||
|
|
|||
| # See if ep is available ... | |||
| ovn_master_host=$(kubectl --server=${K8S_APISERVER} --token=${k8s_token} --certificate-authority=${K8S_CACERT} get ep -n ovn-kubernetes ovnkube-master 2>/dev/null | grep 6642 | sed 's/:/ /' | awk '/ovnkube-master/{ print $2 }') | |||
| ovn_master_host=$(kubectl --server=${K8S_APISERVER} --token=${k8s_token} --certificate-authority=${K8S_CACERT} get ep -n openshift-ovn-kubernetes ovnkube-master 2>/dev/null | grep 6642 | sed 's/:/ /' | awk '/ovnkube-master/{ print $2 }') | |||
There was a problem hiding this comment.
Upstream is different here; shouldn't we be doing the namespace as a configmap value and subbing it into the script?
There was a problem hiding this comment.
yeah, openshift-ovn-kubernetes is 2 months behind upstream right now. it will get ironed out eventually
openshift-merge-robot
pushed a commit
that referenced
this pull request
Mar 29, 2022
Bug 2055379: [release-4.8] fixing network policy
Billy99
added a commit
to Billy99/ovn-kubernetes
that referenced
this pull request
Nov 2, 2022
Host pods were not detected properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ovnkube.shhardcodes the namespace to look for theovnkube-masterservice in, causing the nodes to never come up in a cluster-network-operator-managed cluster.Upstream we should probably fix it so that this comes from an environment variable rather than being hardcoded, so that we don't need to carry a patch.