Bug 1914250: support multipath to detect default gateway #419
Conversation
We were detecting the default gateway based in the assumption that the netlink library was populating the de Gw field with it, however, it turns out that when multipath is enabled that field is empty and the corresponding information is in the MultiPath field. Also, in order to obtain the default gateway, we were dumping all routes filtering by FAMILY_ALL, and iterating on the results to get the ones we are interested. We can filter directly by the IP Family instead, to avoid future possibles problems with the FAMILY_ALL interpretion. Signed-off-by: Antonio Ojea <aojea@redhat.com>
openshift-ci-robot
added
the
bugzilla/severity-high
|
@aojea: This pull request references Bugzilla bug 1914250, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
/assign @abhat |
|
/retest |
|
@aojea: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, dcbw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
lgtm
|
cc @astoycos This may help with the issue you were seeing in KIND with your CNO work. |
|
@aojea: All pull requests linked via external trackers have merged: Bugzilla bug 1914250 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We were detecting the default gateway based in the assumption that
the netlink library was populating the de Gw field with it, however,
it turns out that when multipath is enabled that field is empty and
the corresponding information is in the MultiPath field.
Also, in order to obtain the default gateway, we were dumping all
routes filtering by FAMILY_ALL, and iterating on the results to get
the ones we are interested. We can filter directly by the IP Family instead,
to avoid future possibles problems with the FAMILY_ALL interpretation.
fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1914250