Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1924826: Backport Update gogo/protobuf to v1.3.2. #464

Merged
merged 1 commit into from Apr 16, 2021
Merged

Bug 1924826: Backport Update gogo/protobuf to v1.3.2. #464

merged 1 commit into from Apr 16, 2021

Conversation

vpickard
Copy link
Contributor

Here are the steps I used:

cd go-controller

go list -m all |grep gogo/protobuf
go get github.com/gogo/protobuf v1.3.2
go mod vendor

Add:
github.com/gogo/protobuf => github.com/gogo/protobuf v1.3.2
in the replace section in go.mod, to make we only use this
version.

go mod tidy

Signed-off-by: vpickard vpickard@redhat.com
(cherry picked from commit 0a2aad5)

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

@vpickard vpickard changed the title Update gogo/protobuf to v1.3.2. [Fixes: BZ1924826] Update gogo/protobuf to v1.3.2. Mar 15, 2021
@openshift-ci-robot
Copy link
Contributor

@vpickard: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[Fixes: BZ1924826] Update gogo/protobuf to v1.3.2.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@vpickard: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Update gogo/protobuf to v1.3.2.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vpickard vpickard changed the title [Fixes: BZ1924826] Update gogo/protobuf to v1.3.2. Bug 1924826: Update gogo/protobuf to v1.3.2. Mar 15, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 15, 2021
@openshift-ci-robot
Copy link
Contributor

@vpickard: This pull request references Bugzilla bug 1924826, which is invalid:

  • expected dependent Bugzilla bug 1924535 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1924826: Update gogo/protobuf to v1.3.2.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vpickard
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@vpickard: This pull request references Bugzilla bug 1924826, which is invalid:

  • expected dependent Bugzilla bug 1924535 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vpickard
Copy link
Contributor Author

/retest

1 similar comment
@vpickard
Copy link
Contributor Author

/retest

@vpickard vpickard changed the title Bug 1924826: Update gogo/protobuf to v1.3.2. Bug 1924826: Backport Update gogo/protobuf to v1.3.2. Mar 16, 2021
@vpickard
Copy link
Contributor Author

/retest

@vpickard
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 17, 2021
@openshift-ci-robot
Copy link
Contributor

@vpickard: This pull request references Bugzilla bug 1924826, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1924535 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1924535 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anusaxen@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 17, 2021
@vpickard
Copy link
Contributor Author

/retest

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 21, 2021
@vpickard
Update gogo/protobuf to v1.3.2.
a176beb 
Here are the steps I used:

cd go-controller

go list -m all |grep gogo/protobuf
go get github.com/gogo/protobuf v1.3.2
go mod vendor

Add:
github.com/gogo/protobuf => github.com/gogo/protobuf v1.3.2
in the replace section in go.mod, to make we only use this
version.

go mod tidy

Signed-off-by: vpickard vpickard@redhat.com
(cherry picked from commit 0a2aad5)
Signed-off-by: vpickard <vpickard@redhat.com>
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 22, 2021
@vpickard
Copy link
Contributor Author

/retest

3 similar comments
@vpickard
Copy link
Contributor Author

/retest

@vpickard
Copy link
Contributor Author

/retest

@vpickard
Copy link
Contributor Author

/retest

@rcarrillocruz
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2021
@knobunc
Copy link
Contributor

knobunc commented Mar 31, 2021

/approve

@knobunc
Copy link
Contributor

knobunc commented Mar 31, 2021

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knobunc, rcarrillocruz, vpickard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [knobunc,rcarrillocruz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2021
@mfojtik mfojtik added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 14, 2021
@mfojtik
Copy link
Member

mfojtik commented Apr 14, 2021

[patch-manager] 🚀 Approved for z-stream by score: 1.20

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5fbbe3d into openshift:release-4.7 Apr 16, 2021
@openshift-ci-robot
Copy link
Contributor

@vpickard: All pull requests linked via external trackers have merged:

Bugzilla bug 1924826 has been moved to the MODIFIED state.

In response to this:

Bug 1924826: Backport Update gogo/protobuf to v1.3.2.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeed squeed Awaiting requested review from squeed

@tssurya tssurya Awaiting requested review from tssurya

Assignees

@knobunc knobunc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@vpickard @openshift-ci-robot @rcarrillocruz @knobunc @mfojtik @openshift-bot @openshift-merge-robot