Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1935180: Backport Fix mcast querier #468

Merged
merged 2 commits into from Mar 23, 2021
Merged

Bug 1935180: Backport Fix mcast querier #468

merged 2 commits into from Mar 23, 2021

Conversation

vpickard
Copy link
Contributor

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

@dceara @vpickard
Use link local IPv6 address for MLD queries.
382cd1b 
A valid MLD query *must* be originated with an IPv6 link local source IP
address.  Add function HWAddrToIPv6LLA() to generate a valid link local
address from a MAC address and use it to derive the MLD IPv6 source to
be used by OVN multicast querier.

Fixes: cbc7294 ("Add IPv6 multicast support.")
Signed-off-by: Dumitru Ceara <dceara@redhat.com>
(cherry picked from commit be4b2fb)
@dceara @vpickard
Fix multicast allow policies to include IGMP/MLD traffic.
f5e16a1 
IGMP and MLD traffic must be allowed towards pods if multicast is
allowed, otherwise, ovn-controller generated IGMP/MLD queries will be
dropped.

Fixes: c3def15 ("Add multicast support.")
Signed-off-by: Dumitru Ceara <dceara@redhat.com>
(cherry picked from commit 5657c1e)
@openshift-ci-robot
Copy link
Contributor

@vpickard: This pull request references Bugzilla bug 1935180, which is invalid:

  • expected dependent Bugzilla bug 1935155 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1935180: Backport Fix mcast querier

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 16, 2021
@vpickard
Copy link
Contributor Author

/retest

@vpickard
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@vpickard: This pull request references Bugzilla bug 1935180, which is invalid:

  • expected dependent Bugzilla bug 1935155 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vpickard
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 17, 2021
@openshift-ci-robot
Copy link
Contributor

@vpickard: This pull request references Bugzilla bug 1935180, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1935155 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1935155 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (weliang@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Contributor

dcbw commented Mar 19, 2021

/lgtm

@dcbw
Copy link
Contributor

dcbw commented Mar 19, 2021

/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, vpickard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2021
@ecordell ecordell added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 22, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 6bb08e9 into openshift:release-4.7 Mar 23, 2021
@openshift-ci-robot
Copy link
Contributor

@vpickard: All pull requests linked via external trackers have merged:

Bugzilla bug 1935180 has been moved to the MODIFIED state.

In response to this:

Bug 1935180: Backport Fix mcast querier

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vpickard vpickard mentioned this pull request Mar 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhat abhat Awaiting requested review from abhat

@dcbw dcbw Awaiting requested review from dcbw

Assignees

@dcbw dcbw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@vpickard @openshift-ci-robot @dcbw @openshift-bot @ecordell @openshift-merge-robot @dceara