Bug 1946696: iptables: add filter on node local traffic #489
Conversation
Fixes issue: ovn-org/ovn-kubernetes#1981 This patch simplifies ovnkube-node to remove the notion of node IP. This notion only existed for the iptables rules to be configured correctly. By utilizing `--dst-type LOCAL` we however don't need that anymore and can simplify our logic. Signed-off-by: Alexander Constantinescu <aconstan@redhat.com>
openshift-ci-robot
added
bugzilla/severity-high
|
@alexanderConstantinescu: This pull request references Bugzilla bug 1946696, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anusaxen@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexanderConstantinescu, trozet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
russellb
added
the
cherry-pick-approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@alexanderConstantinescu: All pull requests linked via external trackers have merged: Bugzilla bug 1946696 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Back-port PR to 4.7
This patch simplifies ovnkube-node to remove the notion of node IP.
This notion only existed for the iptables rules to be configured
correctly. By utilizing
--dst-type LOCALwe however don't needthat anymore and can simplify our logic.
Signed-off-by: Alexander Constantinescu aconstan@redhat.com
/assign @trozet
- What this PR does and why is it needed
- Special notes for reviewers
- How to verify it
- Description for the changelog