Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.6] Bug 1953088: master: Delay deleting Namespace's address set for 20 seconds #514

Closed
wants to merge 1 commit into from
Closed

[release-4.6] Bug 1953088: master: Delay deleting Namespace's address set for 20 seconds #514

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #507

/assign knobunc

@squeed
master: Delay deleting Namespace's address set for 20 seconds
eb3f7e9 
In production, it was observed that NetworkPolicies that select all /
many Namespaces often cause errors in ovn-controller:

error parsing match "reg0[7] == 1 && (ip4.dst == { (..snip..): Syntax error at `$a5585560803499416081' expecting address set name.

This is because we first delete the address set, then delete any network
policies that refer to it.

This defers deletion of the address set until 20 seconds have passed.

Signed-off-by: Casey Callendrello <cdc@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 23, 2021
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Bugzilla bug 1951552 has been cloned as Bugzilla bug 1953088. Retitling PR to link against new bug.
/retitle [release-4.6] [release-4.7] Bug 1953088: master: Delay deleting Namespace's address set for 20 seconds

In response to this:

[release-4.6] [release-4.7] Bug 1951552: master: Delay deleting Namespace's address set for 20 seconds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.6] [release-4.7] Bug 1951552: master: Delay deleting Namespace's address set for 20 seconds [release-4.6] [release-4.7] Bug 1953088: master: Delay deleting Namespace's address set for 20 seconds Apr 23, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 23, 2021
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1953088, which is invalid:

  • expected dependent Bugzilla bug 1951552 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.6] [release-4.7] Bug 1953088: master: Delay deleting Namespace's address set for 20 seconds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhat
Copy link
Contributor

abhat commented Apr 26, 2021

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@abhat: This pull request references Bugzilla bug 1953088, which is invalid:

  • expected dependent Bugzilla bug 1951552 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@squeed squeed changed the title [release-4.6] [release-4.7] Bug 1953088: master: Delay deleting Namespace's address set for 20 seconds [release-4.6] Bug 1953088: master: Delay deleting Namespace's address set for 20 seconds May 3, 2021
@squeed
Copy link
Contributor

squeed commented May 3, 2021

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 3, 2021
@openshift-ci-robot
Copy link
Contributor

@squeed: This pull request references Bugzilla bug 1953088, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1951552 is in the state RELEASE_PENDING, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1951552 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anusaxen@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 3, 2021
@squeed
Copy link
Contributor

squeed commented May 3, 2021

/lgtm
/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, squeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 3, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@knobunc knobunc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 6, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

15 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@knobunc knobunc removed the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 7, 2021
@knobunc
Copy link
Contributor

knobunc commented May 7, 2021

/hold

Build error. Investigating

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 7, 2021

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-vsphere-ovn eb3f7e9 link /test e2e-vsphere-ovn
ci/prow/e2e-metal-ipi-ovn-ipv6 eb3f7e9 link /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-azure-ovn eb3f7e9 link /test e2e-azure-ovn
ci/prow/images eb3f7e9 link /test images
ci/prow/e2e-aws-ovn-windows-custom-vxlan eb3f7e9 link /test e2e-aws-ovn-windows-custom-vxlan
ci/prow/e2e-aws-ovn-windows eb3f7e9 link /test e2e-aws-ovn-windows
ci/prow/e2e-gcp-ovn eb3f7e9 link /test e2e-gcp-ovn
ci/prow/e2e-aws-ovn eb3f7e9 link /test e2e-aws-ovn
ci/prow/e2e-metal-ipi-ovn-dualstack eb3f7e9 link /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-ovn-hybrid-step-registry eb3f7e9 link /test e2e-ovn-hybrid-step-registry
ci/prow/e2e-gcp-ovn-upgrade eb3f7e9 link /test e2e-gcp-ovn-upgrade
ci/prow/okd-e2e-gcp-ovn eb3f7e9 link /test okd-e2e-gcp-ovn
ci/prow/okd-images eb3f7e9 link /test okd-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knobunc
Copy link
Contributor

knobunc commented May 7, 2021

@squeed this is failing to compile. Can you take a look please and see how it needs to be re-structured for 4.6?

@squeed
Copy link
Contributor

squeed commented May 10, 2021

Fixed in #534
/close

@openshift-ci openshift-ci bot closed this May 10, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2021

@squeed: Closed this PR.

In response to this:

Fixed in #534
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1953088. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

[release-4.6] Bug 1953088: master: Delay deleting Namespace's address set for 20 seconds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhat abhat Awaiting requested review from abhat

@danielmellado danielmellado Awaiting requested review from danielmellado

Assignees

@squeed squeed

@knobunc knobunc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@openshift-cherrypick-robot @openshift-ci-robot @abhat @squeed @openshift-bot @knobunc