Bug 1956318: Revert "removing the hybrid overlay externalGW code"

[trozet]

Adds back external gw code via hybrid overlay. Also includes various missing unit test fixes downstream that were causing lint and formatting issues.

[openshift-ci-robot]

@trozet: This pull request references Bugzilla bug 1956318, which is invalid:

• expected the bug to target the "4.7.z" release, but it targets "4.8.0" instead
• expected dependent Bugzilla bug 1952262 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1956318: Revert "removing the hybrid overlay externalGW code"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[trozet]

/bugzilla refresh

[openshift-ci-robot]

@trozet: This pull request references Bugzilla bug 1956318, which is invalid:

• expected dependent Bugzilla bug 1952262 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dcbw]

Compared 4.7 before exGW revert to this PR:

git checkout release-4.7
git reset --hard 05894787208a828410c27302e24f57e012a2a44c
git diff ..trozet/bz1956318 go-controller/hybrid-overlay/ go-controller/pkg/ovn/ovn.go go-controller/pkg/ovn/pods.go

and only differences are in pkg/ovn/ovn.go and pods.go. hybrid-overlay code is exactly the same.

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dcbw,trozet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[trozet]

thanks @dcbw

[trozet]

/bugzilla refresh

[openshift-ci-robot]

@trozet: This pull request references Bugzilla bug 1956318, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.z) matches configured target release for branch (4.7.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1952262 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 1952262 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anusaxen@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@trozet: All pull requests linked via external trackers have merged:

• openshift/ovn-kubernetes#521

Bugzilla bug 1956318 has been moved to the MODIFIED state.

In response to this:

Bug 1956318: Revert "removing the hybrid overlay externalGW code"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.