Bug 1956980: [release-4.7] fix ForEachAddressSet() as it is not calling the callback functions #523
Conversation
we have,
external_ids : {name=kube-system_v4}
external_ids : {name=default_v4}
external_ids : {name=default.access-web.egress.3_v4}
external_ids : {name=kube-public_v4}
external_ids : {name=ovn-kubernetes_v4}
external_ids : {name=default.access-web.ingress.0_v4}
external_ids : {name=kube-node-lease_v4}
external_ids : {name=default.access-mysql.ingress.0_v4}
external_ids : {name=default.access-web.egress.0_v4}
so, there is only one part of key=value in `external_ids` and this
results in ForEachAddressSet() not calling the iterator function.
Signed-off-by: Girish Moodalbail <gmoodalbail@nvidia.com>
|
@squeed: This pull request references Bugzilla bug 1956980, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anusaxen@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/severity-unspecified
openshift-ci-robot
added
the
approved
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/severity-low
|
@dcbw: This pull request references Bugzilla bug 1956980, which is valid. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anusaxen@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dcbw, squeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
sdodson
added
the
cherry-pick-approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@squeed: All pull requests linked via external trackers have merged: Bugzilla bug 1956980 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
we have,
external_ids : {name=kube-system_v4}
external_ids : {name=default_v4}
external_ids : {name=default.access-web.egress.3_v4}
external_ids : {name=kube-public_v4}
external_ids : {name=ovn-kubernetes_v4}
external_ids : {name=default.access-web.ingress.0_v4}
external_ids : {name=kube-node-lease_v4}
external_ids : {name=default.access-mysql.ingress.0_v4}
external_ids : {name=default.access-web.egress.0_v4}
so, there is only one part of key=value in
external_idsand thisresults in ForEachAddressSet() not calling the iterator function.
Signed-off-by: Girish Moodalbail gmoodalbail@nvidia.com
- What this PR does and why is it needed
- Special notes for reviewers
- How to verify it
- Description for the changelog