Bug 1959058: policy: release LSP lock before adding pods to default-deny portgroups. #529
Conversation
Profiling indicated a lot of contention on this lock. We should release it before we commit our changes to OVN. Signed-off-by: Casey Callendrello <cdc@redhat.com>
openshift-ci
bot
added
the
approved
|
/lgtm |
|
@squeed needs a bug though |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dcbw, squeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
squeed
changed the title
openshift-ci
bot
added
the
bugzilla/severity-urgent
|
@squeed: This pull request references Bugzilla bug 1950283, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/valid-bug
squeed
changed the title
|
@squeed: This pull request references Bugzilla bug 1959058, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anusaxen@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
bugzilla/severity-unspecified
|
/bugzilla refresh |
openshift-ci
bot
removed
the
bugzilla/severity-unspecified
|
@squeed: This pull request references Bugzilla bug 1959058, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anusaxen@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/severity-high
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/override ci/prow/e2e-vsphere-ovn |
|
@squeed: Overrode contexts on behalf of squeed: ci/prow/e2e-aws-ovn-windows, ci/prow/e2e-vsphere-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
ovn-upgrade failure is synthetic test issues that are being fixed by ensuring pods don't schedule while network plugin is upgraded /retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@squeed: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@squeed: All pull requests linked via external trackers have merged: Bugzilla bug 1959058 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Profiling indicated a lot of contention on this lock. We should release
it before we commit our changes to OVN.
Signed-off-by: Casey Callendrello cdc@redhat.com
This is a backport of ovn-org/ovn-kubernetes#2205